Description text on the retriever settings form says:

Use the Date Format: YYYY-MM-DD HH:MM. This will only be reset if you click 'Reset last run time'

Where's this Reset doodad?

CommentFileSizeAuthor
#4 663798.content_distribution.time-reset-form.patch2.95 KBjoachim

Comments

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

Woah, now you're asking. My deep and foggy memory thinks this is the last run cron time and this is a sort of debug option allowing you to "fake" the last cron run for testing. But I'm not 100%... Actually, it doesn't run on *every* cron - I think the module keeps its own variable

(I should note, I started prototyping this abou 2 years ago and tayzlor did most of the work for the last year...)

tayzlor’s picture

tayzlor commented

i *think* if you just change the time and click on 'save settings' it will get reset to the specified time. as greg mentioned above this is kind of a debugging option so you can set it to say yesterday and try and bring over some content again.
we should probably change the description text for the form field so it does not mention anything about clicking 'reset this... blah..'
I think there was previously a reset button, but it looks like it got removed.

joachim’s picture

joachim commented

The other thing is that saving the settings insists on this value being filled. Which means you're forced to either make up a date and mess up the system, or find out the current date.

joachim’s picture

joachim commented
Status: Active » Patch (to be ported)
StatusFileSize
new 663798.content_distribution.time-reset-form.patch2.95 KB

Ok, so I think the simplest thing is just to allow this field to be empty if you don't want to reset the date variable.

(In the long term, I would split the server settings that you don't touch once they're set up from the date changing and the 'Get stuff' buttons.)

Committed this patch to 6--2.

#663798 by joachim: Fixed date reset option insisting on a date.

(Wacky line numbers probably; due to being cherry-picked out of all my other changes... but applies ok.)

Relevant to 6--1 so marking as needing to be ported.

joachim’s picture

joachim commented
Status: Patch (to be ported) » Fixed

Committed to 6--1.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.