While the development of mongodb_session the following line was in the session test:
$this->assertTrue(db_query('SELECT sid FROM {sessions} WHERE sid = :sid AND ssid = :ssid', $args)->fetchField(), 'Session has both SIDs');
So it would be cool if this sql specific part could be moved out into a extra function and then mongodb session tests could extend the test class much easier.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 663814-10.assertSessionIds.patch | 3.3 KB | dww |
| #9 | 663814-9.assertSessionIdsEquals.patch | 3.32 KB | dww |
| #6 | 663814-5.bothSid.patch | 2.85 KB | dww |
| #3 | 663814-bothSid.patch | 2.65 KB | dawehner |
| #2 | 663814-bothSid.patch | 2.65 KB | dawehner |
Comments
Comment #1
dawehnerHere is the patch
Comment #2
dawehnerNext version.
Comment #3
dawehnerchanged sid to ssid, to make it clear that the ssid is used here
Comment #6
dwwIn IRC DamZ pointed out that a test class function name starting with "test" implies it's actually a test. ;) In this case, we're just checking something. We briefly discussed two options:
A) Name this function checkBothSid().
B) Name it assertBothSid() and move the actual assertion inside.
Here's a patch for (B). All session tests pass locally with this.
Comment #7
chx commentedYay nice.
Comment #8
webchickTwo things:
1. The new assertion needs PHPDoc.
2. assertBothSids() assumes an awful lot of familiarity with how the session system works. Let's make that more obvious. On IRC we decided on assertSessionIdsEquals().
Comment #9
dwwFixes both concerns in #8. All session tests pass locally. This is IMHO RTBC again, but it's my patch so I can't actually say that. ;)
Comment #10
dwwNow that webchick reads the PHPDoc, she agrees with what I proposed in IRC in the first place:
assertSessionIds(). We're not testing if two session IDs are equal. We're testing if there's a session with both sids...Comment #11
webchickAwesome, thanks. Committed to HEAD!