Somehow we missed aligning edit shortcuts to the middle, right now it draws to much attention by being mis aligned.

CommentFileSizeAuthor
#23 shortcuteditlink.patch3.27 KBcasey
#18 shortcuteditlink.patch3.16 KBcasey
#11 shortcuteditlink.patch3.01 KBcasey
#1 editshortcutsalign.png3.01 KBBojhan
align.editshortcuts.patch739 bytesBojhan

Comments

Bojhan’s picture

Bojhan commented
Status: Active » Needs review
StatusFileSize
new editshortcutsalign.png3.01 KB

editshortcutsalign.png

dries’s picture

dries commented

While we're on the topic of the 'edit shortcuts' link -- shouldn't it be 'Edit shortcuts' (i.e. capital 'E') to be consistent with the other links?

Bojhan’s picture

Bojhan commented

I guess so yes, let me ask mark though - I recall seeing lowercase on his wireframes, his reasoning will help us make a decision.

David_Rothstein’s picture

David_Rothstein commented

This definitely seems like an improvement, but on the other hand, the "edit shortcuts" link now looks like a bit like a shortcut itself... do we need some way to visually distinguish them?

About the capitalization, Drupal seems to not be very consistent here (in many many places "edit" links are explicitly lower-case) so sounds like it might be a separate issue...

markboulton’s picture

markboulton commented

I'm thinking it should be 'Edit shortcut' as Dries suggested. Alignment in that grab looks good to me too. Visually distinguishing might be a good thing actually - it could be slightly smaller. I wouldn't want to draw too much attention to it simply because it will start competing with other elements.

Status: Needs review » Needs work
Issue tags: -Usability, -D7UX

The last submitted patch failed testing.

Status: Needs work » Needs review

Re-test of from comment #0 was requested by @user.

Status: Needs review » Needs work
Issue tags: +Usability, +D7UX

The last submitted patch, , failed testing.

Bojhan’s picture

Bojhan commented

Ok, going for "Edit shortcuts" this is also far more consistent with the other links in the top bar, its already distinctive enough by its position.

casey’s picture

casey commented
Status: Needs work » Needs review
StatusFileSize
new shortcuteditlink.patch3.01 KB
mrfelton’s picture

mrfelton commented

Patch applied and tested... Looks good to me.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Same for me...
I don't think this needs extra documentation...

jbrown’s picture

jbrown commented

It is inconsistent that the link is Edit shortcuts, but the page that it links to has the title Customize shortcuts.

yoroy’s picture

yoroy commented
Status: Reviewed & tested by the community » Needs review

Good point. Dashboard has a 'Customize' link as well. These are interactions of the same type: user specific customization. Should it be Customize here too?

yoroy’s picture

yoroy commented
Status: Needs review » Needs work

Also, we did some design work on this and decided to go for the first option:

Only local images are allowed.

- normal state for this link has color #bbb,
- hover and active state for this link should be added and change the color to #fff

Bojhan’s picture

Bojhan commented

Actually it shouldn't be customize on the other page, it should be Edit.

casey’s picture

casey commented
Status: Needs work » Needs review
StatusFileSize
new shortcuteditlink.patch3.16 KB
dries’s picture

dries commented 
+++ modules/shortcut/shortcut.module	5 Jan 2010 15:32:02 -0000
@@ -594,7 +594,7 @@
       '#options' => array('attributes' => array('id' => 'toolbar-customize')),

I think it would help if we renamed the CSS ID to 'edit-shortcuts'. Then it follows the link name ... thoughts?

casey’s picture

casey commented

Don't we have to use "{module}-{identifier}" style IDs and classes?

Shouldn't we use something like "shortcut-edit-toolbar"?

dries’s picture

dries commented

Either work for me! :)

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Regarding the word "Customize" as opposed to Edit, see also #677534: Customize still being used in place of Edit

casey’s picture

casey commented
StatusFileSize
new shortcuteditlink.patch3.27 KB
mrfelton’s picture

mrfelton commented
Status: Needs review » Reviewed & tested by the community

Works for me, tests pass and seems to address all the concerns mentioned herein so marking as RTBC.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Usability, -D7UX

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Usability, +D7UX

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.