The new standard in Drupal core is to avoid using field set if there is only one present or when it is the main interaction. Here the same applies because, there are vertical tabs but the actual Identification fieldset holds no value.

CommentFileSizeAuthor
#13 drupal.comment-node-type.patch710 bytessun
#10 content-types-fieldset-locale-664012-10.patch838 bytescburschka
#6 content-types-fieldset.patch1.32 KBdries
#1 fieldsetnodetypesremoval_before.png15.17 KBBojhan
#1 fieldsetnodetypesremoval_after.png14.38 KBBojhan
#1 removal.fieldsetnodetypes.patch1005 bytesBojhan

Comments

Bojhan’s picture

Bojhan commented
StatusFileSize
new removal.fieldsetnodetypes.patch1005 bytes
new fieldsetnodetypesremoval_after.png14.38 KB
new fieldsetnodetypesremoval_before.png15.17 KB

fieldsetnodetypesremoval_before.png

After

fieldsetnodetypesremoval_after.png

yoroy’s picture

yoroy commented
Status: Active » Needs review

bot?

dries’s picture

dries commented

If we remove the fieldset, we can simplify the rest of the form API structure too. We move things up from the second level, to the first level in the array.

Bojhan’s picture

Bojhan commented

So removing ['identity'] from those which where in the fieldset, oke.

dries’s picture

dries commented

Correct.

dries’s picture

dries commented
StatusFileSize
new content-types-fieldset.patch1.32 KB

Here is an updated patch. Ran the Node tests locally with ($ /Applications/acquia-drupal/php/bin/php scripts/run-tests.sh --url http://cvs.localhost:8082/ --php /Applications/acquia-drupal/php/bin/php Node) and they still pass.

Bojhan’s picture

Bojhan commented
Status: Needs review » Reviewed & tested by the community

Ahh, cool :) Faster then me, I just tested it and it works. RTBC

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

cburschka’s picture

cburschka
they
commented
Category: task » bug
Priority: Normal » Critical
Status: Fixed » Needs work

locale.module, in locale_form_node_type_form_alter() depends on the [identity][type] key and should have been updated to [type].

This caused #666402: Translation workflow options are broken which in turn is causing part of #666266: HEAD is broken - various test failures.

cburschka’s picture

cburschka
they
commented
Status: Needs work » Needs review
StatusFileSize
new content-types-fieldset-locale-664012-10.patch838 bytes

This is wonderful - the one-line patch actually fixes *all* of translation.module's test failures. :)

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Test bot, we have missed you.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks, Arancaytar.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Fixed » Needs work
StatusFileSize
new drupal.comment-node-type.patch710 bytes

Also broke Comment module's form alter.

1) We should check all other hook_form*_alter() implementations.

2) We badly need the testbot back.

dries’s picture

dries commented

Committed #13 to CVS HEAD. We still need tests, so leaving at 'needs work'.

yoroy’s picture

yoroy commented

Is 'needs tests' still a critical?

Bojhan’s picture

Bojhan commented
Priority: Critical » Normal
Issue tags: -Usability +Needs tests

Doesn't seem critical.

Tor Arne Thune’s picture

Tor Arne Thune commented
Title: Removal of Identification fieldset » (Tests needed) Removal of Identification fieldset
Version: 7.x-dev » 8.x-dev
Assigned: Bojhan » Unassigned
Issue tags: +Needs backport to D7

I suppose this still needs tests.

catch’s picture

catch
he/him
Primary language English
commented
Category: bug » task
xjm’s picture

xjm
she/her
Primary language English
commented
Component: node.module » node system
Issue summary: View changes

(Merging "node system" and "node.module" components for 8.x; disregard.)

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

  • Dries committed 275fc6b on 8.3.x 
    - Patch #664012 by Bojhan, Dries: removed unnecessary fieldset.
  • Dries committed 4f32e41 on 8.3.x
    - Patch #664012 by sun: fixed comment settings.
  • Dries committed c28317a on 8.3.x
    - Patch #664012 by Arancaytar: fixed the translation tests.

  • Dries committed 275fc6b on 8.3.x 
    - Patch #664012 by Bojhan, Dries: removed unnecessary fieldset.
  • Dries committed 4f32e41 on 8.3.x
    - Patch #664012 by sun: fixed comment settings.
  • Dries committed c28317a on 8.3.x
    - Patch #664012 by Arancaytar: fixed the translation tests.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

  • Dries committed 275fc6b on 8.4.x 
    - Patch #664012 by Bojhan, Dries: removed unnecessary fieldset.
  • Dries committed 4f32e41 on 8.4.x
    - Patch #664012 by sun: fixed comment settings.
  • Dries committed c28317a on 8.4.x
    - Patch #664012 by Arancaytar: fixed the translation tests.

  • Dries committed 275fc6b on 8.4.x 
    - Patch #664012 by Bojhan, Dries: removed unnecessary fieldset.
  • Dries committed 4f32e41 on 8.4.x
    - Patch #664012 by sun: fixed comment settings.
  • Dries committed c28317a on 8.4.x
    - Patch #664012 by Arancaytar: fixed the translation tests.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

  • Dries committed 275fc6b on 9.1.x 
    - Patch #664012 by Bojhan, Dries: removed unnecessary fieldset.
  • Dries committed 4f32e41 on 9.1.x
    - Patch #664012 by sun: fixed comment settings.
  • Dries committed c28317a on 9.1.x
    - Patch #664012 by Arancaytar: fixed the translation tests.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue summary: View changes

.

acbramley’s picture

acbramley commented
Status: Needs work » Fixed

TY for fixing filter access @larowlan

This one was committed and not closed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.