I've found a bug, there's a thread about it: http://drupal.org/node/664532

Comments

Freakmeister’s picture

Freakmeister commented

Here's first post in case moderators delete this thread:

Yesterday I've installed this module: http://drupal.org/project/guestbook
And I've done so many changes in it by now... but about hour ago I've found a bug, that came with original module!

When you making a new record in guestbook as guest, there's two fields that not necessary to fill: "E-mail" and "Website". If you fill them both, or not fill them BOTH - everything goes just fine. But if you didn't fill just one of them, then new record doesn't goes to database on submit - it's just redirects you to the same guestbook page.

Please help! My 2 days work on costumizing this module goes to hell, because I can't fix the original problem. ;(

tjodolv’s picture

tjodolv commented

I just downloaded the 6.x-1.1 version and tested it. I can not reproduce your problems. Submitting an entry in the guestbook works for me.

I tried submitting with:

  • Just a name and a comment.
  • Name, email and comment.
  • Name, website and comment.
  • Name, email, website and comment.

Everything works fine for me. I can also delete entries and comment on them. I did not try the dev version, but 1.1 seems to work just fine as far as I can tell. Do you have any other modules - downloaded or custom - which might cause problems?

Also, it is generally not wise to modify modules. If the module is updated in the future, and you update, you will need to redo your custom modifications all over again. It is generally better to create a separate module which hooks into this module and adds your custom functionality. This way, it is also easier to maintain the changes when the original module (Guestbook, or any other) changes in the future. If the modifications you have done are only with the way the module looks or "feels", you should simply use the theme layer to make your modifications.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Category: bug » support
Priority: Critical » Normal
Status: Needs work » Closed (cannot reproduce)

Sorry, without further information this issue can only be closed as not reproducible.

Feel free to re-open this issue if you want to provide further information. Thanks.