Share very broken if you enable block caching

The default value for the 'cache' attribute in hook_block('list') is BLOCK_CACHE_PER_ROLE (1). This wreaks havoc with share.module if you use any block widgets and turn on block caching, since the blocks are shared across all pages on your site for users of the same role, even though the whole point of the share blocks is that they're custom links specific to the page you're on.

Therefore, you need to define 'cache' = BLOCK_CACHE_PER_PAGE in hook_block().

Better yet, since core is busted (#235673: Changes to block caching mode not caught ugh) simply changing the code isn't sufficient. You also need a DB update to make the change take effect for existing sites(!). Yee haw.

One sec, I'll post a patch...