Today I was surprised by white screen in my website (when I visited). I have looked for something in error logs on server and i have found an information such This:

[Mon Dec 21 09:10:06 2009] [error] [client 83.2.72.35] ALERT - canary mismatch on efree() - heap overflow detected (attacker '83.2.72.35', file '/srv/www/vhosts/****/httpdocs/sites/all/modules/better_messages/better_messages.module', line 50)

I have uninstalled a Better Messages module and removed all remains off the database. The website is working now !!!

CommentFileSizeAuthor
#3 664856_better_messages.patch939 bytesreubenavery

Comments

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
commented
Priority: Normal » Critical

Have a similar problem on a site under development. I looked in the code and I am quite sure that the reason is the use of file_scan_directory() on every page load where a message exists! To be honest is it quite insane to use this function here. It should of course only be used on the settings page in the administration, and all other places use the configured skin.

reubenavery’s picture

reubenavery commented

subscribing.

reubenavery’s picture

reubenavery commented
StatusFileSize
new 664856_better_messages.patch939 bytes

I modified this function to store the skin files inside the drupal cache. Here's a patch. Can anyone think of a scenario where this might be a bad thing to do?

reubenavery’s picture

reubenavery commented
Status: Active » Needs review
mohammed j. razem’s picture

mohammed j. razem
Location Santa Clara, CA
commented
Status: Needs review » Fixed

New release that fixed this.

Skins are no longer needed by Better Messages, instead you can override the .tpl and .css as per your themes.

See #607086: Overriding template

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.