Wrong t() usage in apachesolr_field_name_map() [#664860]

This code will never give what you'd expect:

    foreach (apachesolr_cck_fields() as $name => $field) {
      $map[apachesolr_index_key($field)] = t('CCK @type field %label', array('@type' => $field['index_type'], '%name' => $field['label']));
    }

Typo error, you should write this:

    foreach (apachesolr_cck_fields() as $name => $field) {
      $map[apachesolr_index_key($field)] = t('CCK @type field %label', array('@type' => $field['index_type'], '%label' => $field['label']));
    }

Sorry for not submitting a patch, this is just a word to change.

Comment	File	Size	Author
#1	664860.patch	888 bytes	robertdouglass

Comments

Comment #1

robertdouglass commented 21 December 2009 at 13:15

Status:

Active

» Fixed

Status	File	Size
new	664860.patch	888 bytes

#664860 by pounard: Fixed Wrong t() usage in apachesolr_field_name_map().

Good catch. Thanks.

Comment #2

pounard

French

commented 21 December 2009 at 14:15

You're welcome :)

Comment #3

4 January 2010 at 14:20

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #4

cjdavis commented 5 January 2011 at 21:53

Status:

Closed (fixed)

» Active

Almost there - it should be $field['name'] rather than $field['label'], so:

    foreach (apachesolr_cck_fields() as $name => $field) {
      $map[apachesolr_index_key($field)] = t('CCK @type field %label', array('@type' => $field['index_type'], '%label' => $field['label']));
    }

And some keywords in case anyone is searching like I was:
This affects the Field biases section of the Search fields tab of the Apache Solr settings, located at /admin/settings/apachesolr/query-fields. Also 'Apache Solr recommendations: More like this' block configuration, under 'Fields for finding related content' The problem is seeing only 'CCK text field' without the actual field name appended.