Hi,

I am seeing the Activity Log tab on all content types, and not just the Ad type. This doesn't seem to make sense, and instead I would have expected to see this only when viewing an Ad node.

Also, the Activity Log tab itself seems to be randomly positioned in the list - can this be moved at all?

Thanks

Comments

wim leers’s picture

Category: support » bug
Priority: Normal » Minor

Confirmed. Quite annoying.

TUc’s picture

Indeed very annoying. It should at least not show up on unrelated content types.

WebNewCastle’s picture

Is this being looked into further?

jeremy’s picture

Assigned: Unassigned » jeremy
Priority: Minor » Normal

I'm hoping to go through the issue queue soon tackling some of these types of bugs. Assigning to myself to remember, should be an easy fix.

WebNewCastle’s picture

Oh, ok. That's awesome. I was just wondering. I noticed it on a site where I was helping to upgrade some functionality. Given that I typically have local tabs pushed up into the admin menu bar it's tucked out of the way, but I just wondered. Great work on the module overall! - it's nice to be able to have this on sites.

aidanlis’s picture

Yeh, I'm getting this too ... this patch fixes it:

diff --git a/html/sites/all/modules/patched/ad/ad.module b/html/sites/all/modules/patched/ad/ad.module
index e41c218..f234127 100644
--- a/html/sites/all/modules/patched/ad/ad.module
+++ b/html/sites/all/modules/patched/ad/ad.module
@@ -1318,6 +1318,11 @@ function ad_permission($aid, $string, $account = NULL) {
global $user;
$access = FALSE;

+ // check the content type
+ if (is_object($aid) && $aid->type !== 'ad') {
+ return FALSE;
+ }
+
// by default, check permission for current user
if (!isset($account)) {
$account = $user;

wiifm’s picture

Applied patch from #6, can confirm that this fixes the issue. Thanks

budda’s picture

Status: Active » Reviewed & tested by the community

patch works, would be nice to get it in the next release - or even the dev build.

jeremy’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, patch committed:
http://drupal.org/cvs?commit=370074

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.