Closed (fixed)
Project:
Advertisement
Version:
6.x-2.2
Component:
ad module
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
21 Dec 2009 at 13:18 UTC
Updated:
4 Jun 2010 at 20:10 UTC
Hi,
I am seeing the Activity Log tab on all content types, and not just the Ad type. This doesn't seem to make sense, and instead I would have expected to see this only when viewing an Ad node.
Also, the Activity Log tab itself seems to be randomly positioned in the list - can this be moved at all?
Thanks
Comments
Comment #1
wim leersConfirmed. Quite annoying.
Comment #2
TUc commentedIndeed very annoying. It should at least not show up on unrelated content types.
Comment #3
WebNewCastle commentedIs this being looked into further?
Comment #4
jeremy commentedI'm hoping to go through the issue queue soon tackling some of these types of bugs. Assigning to myself to remember, should be an easy fix.
Comment #5
WebNewCastle commentedOh, ok. That's awesome. I was just wondering. I noticed it on a site where I was helping to upgrade some functionality. Given that I typically have local tabs pushed up into the admin menu bar it's tucked out of the way, but I just wondered. Great work on the module overall! - it's nice to be able to have this on sites.
Comment #6
aidanlis commentedYeh, I'm getting this too ... this patch fixes it:
diff --git a/html/sites/all/modules/patched/ad/ad.module b/html/sites/all/modules/patched/ad/ad.module
index e41c218..f234127 100644
--- a/html/sites/all/modules/patched/ad/ad.module
+++ b/html/sites/all/modules/patched/ad/ad.module
@@ -1318,6 +1318,11 @@ function ad_permission($aid, $string, $account = NULL) {
global $user;
$access = FALSE;
+ // check the content type
+ if (is_object($aid) && $aid->type !== 'ad') {
+ return FALSE;
+ }
+
// by default, check permission for current user
if (!isset($account)) {
$account = $user;
Comment #7
wiifmApplied patch from #6, can confirm that this fixes the issue. Thanks
Comment #8
buddapatch works, would be nice to get it in the next release - or even the dev build.
Comment #9
jeremy commentedThanks, patch committed:
http://drupal.org/cvs?commit=370074