Gigya socialize retrieves the social connections of the currently logged in user (facebook profile, myspace profile and so on ) and displays them in all "users/xyz" pages. In my opinion they should better be hidden (except in "users/currentuser" of course)

Comments

Gigya’s picture

Gigya commented

Hi Tito,
y
Thanks for reaching out about this. It is by design, although I agree that in some cases users won't want to have their Social Network
profile shown to other users. Currently our team is focused on fixing a few more issues and adding more features, so we don't have too much time for other issues. if you want to add this option to the code and need our help, we would be happy to help with guidance.

The Gigya Team.

tito.brasolin’s picture

tito.brasolin commented

The problem is that I'm seeing my social connections even when I'm looking at another user's profile.

In function gigya_user (implementation of hook_user) gigya_getUserInfo($account->uid) always gets the informations of the currently logged in user.

In my opinion, the problem is in gigya.inc, function gigya_getUserInfo($gigya_uid)

[...]
if ( $user && ($user->uid)>0 ) {
$gigya_params['uid'] = $user->uid; // <- always executed if the user is logged in
}
else {
$gigya_params['uid'] = $gigya_uid;
}
[...]

If the user is logged in, the parameter $gigya_uid is always ignored and $user->uid is used instead.

cerup’s picture

cerup commented

Yeah, I see the same thing. I see my own social connection(s) when looking at another users profile.

EvanDonovan’s picture

EvanDonovan commented
Version: 6.x-1.0-beta9 » 6.x-2.0

@azinck: This still happens in 6.x-2.0, doesn't it?

This cannot be by design. The AJAX call shouldn't retrieve your user profile information if you are on someone else's page.

azinck’s picture

azinck commented

Don't know what qualifies as "by design" with this module anymore. I agree that it shouldn't happen. The problem is the "desired" behavior of the module hasn't really been defined. It's probably worth doing a wholesale reevaluation of how Gigya should integrate with account pages but I think the low hanging fruit here is to just remove the display of the networks a user is connected to on the user/uid/edit page. What do you think?

EvanDonovan’s picture

EvanDonovan commented

I guess the easiest thing for now would be to make it so that users could edit their own linkages, but not let them see other people's, until a fix is made for the JS. I don't know the Gigya JS API (yet?) so I don't know if it would be possible. Might have to "mock up" a Gigya connection for that UID, but would that lose that current user's connection.

Agreed that "desired" behavior of the module is currently undefined.

azinck’s picture

azinck commented
Version: 6.x-2.0 » 6.x-2.1
Status: Active » Fixed

This is fixed. Please confirm

steingard’s picture

steingard commented

You said this is fixed in 6.x-2.1, but I don't see evidence of this. What's the solution? Is there a patch?

azinck’s picture

azinck commented

Hi steingard,

No patch. I think this is fixed by some work I did a while back. I just didn't come back to the issue and close it out. Are you still seeing the problem? I couldn't reproduce it on 2.1 and a couple of months ago I changed the code that comment #2 refers to.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.