#663246: Port to Drupal 7 contained a couple of fixes that should be backported to DRUPAL-6--1

CommentFileSizeAuthor
#1 mollom-DRUPAL-6--1.d7-backport.patch16.15 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review
StatusFileSize
new mollom-DRUPAL-6--1.d7-backport.patch16.15 KB

Only noteworthy change in this patch:

  • #access and #required is removed from admin settings, because you cannot change the fallback behavior without disabling the module. Usually, when building a site that will use Mollom, I'm just installing it first, and may leave the actual configuration for later. Since the default fallback method is to block all submissions, you cannot do that. Also helps in manual testing.
dries’s picture

dries commented

Note that I haven't kept track of all the bug fixes that went into the Drupal 7 version, but that still need to be backported to Drupal 6.

dries’s picture

dries commented

Is this backport a side-effect of the other changes in the DRUPAL-6--1 branch? With the latest stable release of the Drupal 6 module, I can change the fallback setting just fine -- and those fields could be required just fine too.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Did you try to change the fallback behavior directly after installing the module? I.e. when no API keys are configured yet?

dries’s picture

dries commented

Committed #1 to DRUPAL-6--1 because you were 100% right. :)

Are there more fixes to backport?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Thanks! Nope, that's it :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.