Seen in system_service.module.

CommentFileSizeAuthor
#5 665278.patch9.63 KBgdd
#2 665278.patch9.64 KBgdd

Comments

gdd’s picture

Title: admin/modules#description obsolete » Revamp hook_help() implementations.

Looking into this I noticed there are several problems with the hook_help() implementations throughout Services

- Multiple references to deprecated admin/modules#description.
- Improperly named paths result in no submodules showing up on the Help page at all, regardless of whether they're enabled or not.
- In general all the help text is completely useless.

I am kind of pondering the idea of extensively expanding the hook_help() implementation in services.module and just removing it for all the submodules. What do people think of this?

gdd’s picture

Status: Active » Needs review
StatusFileSize
new9.64 KB

OK, so that is exactly what I've done. I took the introductory text from the handbook page and spiced it up a little, then removed all the other hook_help() implementations, none of which were actually doing anything. Honestly I don't think they have much use, the documentation in the browser is much more extensive and contextual (who actually visits admin/help anyways?)

Patch attached, I'll give it a day or two to give people a chance to speak up.

joachim’s picture

Looks good!

marcingy’s picture

Status: Needs review » Needs work

There might be some coding standards issues in this patch we aren't using the . delimiter correctly. Mix of old d6 style and new d7 style. Otherwise is good in terms of new help text.

gdd’s picture

StatusFileSize
new9.63 KB

Damn you D6 stupid coding standards! I have committed the attached patch which is fixed.

gdd’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.