dhtml_menu.admin.inc contains some untranslatable strings
$options['animation']['speed'] = array(
'#type' => 'select',
'#title' => t('Speed'),
'#options' => array(100 => 'Very Fast (0.1s)', 500 => 'Fast (0.5s)', 1000 => 'Medium (1s)', 1500 => 'Slow (1.5s)', 2000 => 'Very Slow (2s)'),
'#default_value' => $settings['animation']['speed'],
'#description' => t('Choose how quickly the menus should expand and collapse.'),
);
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | dhtml_menu-665920-5-translateable-speeds.patch | 1.15 KB | cburschka |
| #3 | dhtml_menu-665290-4-translateable-speeds.patch | 1.15 KB | cburschka |
| #2 | dhtml_menu-665290-3-translateable-speeds.patch | 1.15 KB | cburschka |
| #1 | dhtml_menu-665290-2-translateable-speeds.patch | 1.05 KB | cburschka |
Comments
Comment #1
cburschkaWhoops. Thanks for the heads-up.
Here's a patch for HEAD. This will need to be fixed in 6.x-4.x-dev as well.
Comment #2
cburschkaEh; it's been a while since I did this. Of course t() takes an associative array; there's also a syntax error.
Comment #3
cburschka... and indentation.
Comment #4
arhak commentedif numeric values are (hard coded) constants then variables are not required (unless you're thinking to save some translator's time if you change them in the future)
anyway
!secondsis not needed,@secondsseems more appropriate (there is no markup involved)Comment #5
cburschkaYou're right that the values are unlikely to change, but it leaves that option open with no real downside.
But yeah, @ is the way to go. I usually use either % or ! by reflex, but since this is inside a tag attribute % would be completely wrong.
Comment #6
cburschkaI've committed this change to HEAD and to DRUPAL-6--4 (along with a newly generated dhtml_menu.pot template).