Download & Extend

simplify access functions in distributor_service module, and use the delete permission

Project:Content Distribution
Version:6.x-1.x-dev
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

There's no need for distributor_service_get_access() and co when all they do is run user_access(), and hook_services's '#access callback' key defaults to user_access() anyway.

Furthermore, distributor_service_delete_access() is never actually used anywhere. This means that 'delete distributed nodes' permission has no effect; presumably the intention was to have it on the node.deleteDistributedNode service.

Comments

#1

Actually, what I mean is that the 'delete distributed nodes' permission isn't defined anywhere!

#2

Status:active» fixed

Fixed.

Patch attached in case other maintainers want to check I've not done anything insane ;)

AttachmentSize
665294.content_distribution.services-access-cleanup.patch 3.07 KB

#3

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here