There's no need for distributor_service_get_access() and co when all they do is run user_access(), and hook_services's '#access callback' key defaults to user_access() anyway.

Furthermore, distributor_service_delete_access() is never actually used anywhere. This means that 'delete distributed nodes' permission has no effect; presumably the intention was to have it on the node.deleteDistributedNode service.

Comments

joachim’s picture

Actually, what I mean is that the 'delete distributed nodes' permission isn't defined anywhere!

joachim’s picture

Status: Active » Fixed
StatusFileSize
new3.07 KB

Fixed.

Patch attached in case other maintainers want to check I've not done anything insane ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.