This patch fixes a bunch of php notices and it also uses url() properly for a comment/node. A node doesn't have to have a path, and that path isn't needed for the l() or url() functions. Just pass in node/$nid

CommentFileSizeAuthor
blueprint_comment_notices.patch1.74 KBScott Reynolds

Comments

designerbrent’s picture

designerbrent commented
Status: Needs review » Fixed

Thanks for your work on this Scott. It has now been committed: http://drupal.org/cvs?commit=311428

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Closed (fixed) » Patch (to be ported)

Since 2.x is still in development, it would be nice if this, and other fixes, were applied to the 1.x branch as well.

Thanks,

Jonathan

designerbrent’s picture

designerbrent commented
Version: 6.x-2.x-dev » 6.x-1.x-dev
Status: Patch (to be ported) » Fixed

This was just committed and will be in the next release of the blueprint 1.x module.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.