Hi,
I (and others?) are finding it hard to style the heading

Location

, because it's not wrapped in a div. Related to #432232: location.tpl.php puts map link outside divs.
I've attaching a patch that fixes this. (I see you have a backlog of issues - good luck!)

Thanks, Nick

CommentFileSizeAuthor
patch_olnet_location_tpl_ndf_22dec2009.diff558 bytesnfreear

Comments

nfreear’s picture

nfreear commented

As background, this is how we're using the location module, with the http://drupal.org/project/event module - the relevant style sheet rules are embedded in the page here,

http://olnet.org/node/155

Is there anyway that the location and event modules could "match" their output - that is, use similar markup?

Nick

yesct’s picture

yesct commented
Status: Active » Needs review
Issue tags: +Location theming, +location bdragon consider commit
ankur’s picture

ankur commented
Status: Needs review » Fixed

Committed a modified version of the patch (using different classes) to HEAD and DRUPAL-6--3

yesct’s picture

yesct commented

http://drupal.org/cvs?commit=353362
http://drupal.org/cvs?commit=353360

yesct’s picture

yesct commented
Issue tags: -location bdragon consider commit

updating tags

gooddesignusa’s picture

gooddesignusa commented

This broke my theme. The content area was all messed up. Took me awhile to figure what exactly did it when updating to the newest dev. Ended up being that closing div. It should be wrapped inside the if statement. It was printing a closing div after the content on normal nodes that did not have a location.

<?php if (count($locations)) {?>
<h3 class="location-locations-header"><?php echo count($locations) > 1 ? t('Locations') : t('Location');?></h3>
<div class="location-locations-wrapper">
<?php
  foreach ($locations as $location) {
    echo $location;
  }
  echo "</div>";
} ?>
yesct’s picture

yesct commented
Category: feature » bug
Status: Fixed » Needs work

OK. Someone needs to make a patch. gooddesignusa, did you change the file to make it go inside the if on your site? Please post a patch: http://drupal.org/patch/create

diff -up path/to/file/example.module path/to/file/exampleNew.module > mypatchname.patch
so if you have locations.tpl.php (the original file) and locations.tpl.php.new (the new file with the div inside the if)
then run:
diff -up locations.tpl.php locations.tpl.php.new > putdivinsideif.patch

or something similar. :)

hutch’s picture

hutch commented

Already done, see #769094: locations.tpl.php bug
http://drupal.org/files/issues/locations.tpl_.php-bad-close-div_0.patch

yesct’s picture

yesct commented
Category: bug » feature
Status: Needs work » Fixed

ok back to fixed. Thanks hutch for pointing out the other issue!

Status: Fixed » Closed (fixed)
Issue tags: -Location theming

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Location theming

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.