There is an inline comment inside a t() function, that states "We don't use function_exists() here...". But function_exists() is actually used three lines below the comment.

I found that it was added with the patch in #407256: Make t() more robust. The feature was reverted, but the comment is still there. And it is really confusing.

CommentFileSizeAuthor
remove-comment.patch847 bytes20th

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Active » Reviewed & tested by the community

This looks quite reasonable, and should not break any tests (the patch simply removes three lines of misleading comments).

For future reference, v_20q, you should set the status of your issue to "Needs Review" when you attach a patch, so that it will be tested.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

20th’s picture

20th commented

@jhodgdon
I didn't know that, thank you!

@Dries
Thank you very much!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.