drupalorg_search is throwing a fatal error because it is calling deprecated apachesolr functions (get_fields, remove_field, add_field). I have replaced those elements with the new "filter" version of each.
Likewise - and maybe this is just because I'm trying to do this locally - facet.field is not set by default, therefore I get a foreach warning on the foreach over face.field. I protected against this with a simple is_array check. This may not be necessary for the production environment, but it seemed like good practice here anyhow.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | drupalorg-search.patch | 2.01 KB | csevb10 |
| #7 | drupalorg-search.patch | 1.39 KB | csevb10 |
| drupalorg-search.patch | 1.4 KB | csevb10 |
Comments
Comment #1
rfayWe can go ahead and get a start on this by putting this into the modules sandbox on all 10 staging sites. I'll see if I can do that later today. We won't put it into the redesign branch until it's gotten committed into CVS.
Comment #2
damien tournoud commentedThis one should probably be a
isset(). Hiding the error in case facet.field is not an array falls into the "don't babysit broken code" rule.Otherwise, this looks great. I can commit once this is tested on the staging site.
Comment #3
rfayNote that when we tried to deploy this patch on staging9 we got many (random) errors as mentioned on #666590: Staging9: Fatal Error: Cannot redeclare (various).
Turning off APC got rid of the erors.
Comment #4
Amazon commentedWe are trying to debug this APC problem.
The site is made up of three directories. https://svn.drupal.org/drupal/drupal.org/redesign/, https://svn.drupal.org/drupal/redesign_modules_sandbox/staging9/, https://svn.drupal.org/drupal/themes/sandbox/
We confirmed that the /staging9 is running "At revision 2216"
Rfay checked out the code locally and uses APC without incident.
Comment #5
calebgilbert commentedFyi, the APC issue has been fixed, but the fatal errors will still exist on all the staging sites except staging9 since only staging9 has the patched drupalorg/search modules on it at the moment.
Comment #6
Amazon commentedI've enabled the meta-type filter blocks on staging9. Initial testing seems to indicate they work.
http://staging9.drupal.org/search/apachesolr_search/test
We are trying to implement: https://infrastructure.drupal.org/drupal.org-style-guide/prototype/searc...
The correct settings can be set here: http://staging9.drupal.org/admin/settings/apachesolr/enabled-filters
Comment #7
csevb10 commentedisset instead of is_array
Comment #8
damien tournoud commentedCommitted to HEAD.
Comment #9
csevb10 commentedA patch for the meta_types search to correct additional deprecated functions.
Comment #10
damien tournoud commentedCommitted. The fatal error is fixed, but the facet doesn't work as intended: you cannot unselect an item when selected.
Comment #11
damien tournoud commentedCommitted http://drupal.org/cvs?commit=308310
That fixes the behavior of the facet, and closes this issue.
Comment #12
rfayI rolled this out on the staging sites today (in the redesign branch).
Any drupalorg modules that were in the modules sandbox were deleted in favor of this one.
Comment #13
jwilson3doh! this may have inadvertently deleted various peoples work by deleting stuff from staging module sandboxes.
Please do take care with that.
Luckily i do still have a local copy of my stuff, and I hadn't committed anything of utter importance yet.
PS. I'm under the impression now from DamZ and Caleb G that if i need to do work on drupalorg module, i get it direct from cvs head, and put it in redesign_module_sandbox/stagingX/patched/ and its up to me to keep it in sync. This is kinda non-optimal solution since we supposedly already have svn-cvs syncing in place. I filed an issue on this exact problem here: #679264: improve repository syncing, streamline workflows for development with svn
Comment #14
rfayjrguitar21, your work is still in svn. You shouldn't have any trouble getting it. You can create a patch from it and submit to cvs.