Posted by boombatower on December 22, 2009 at 8:35pm
Jump to:
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | base system |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
| Issue tags: | coding standards |
Issue Summary
I have coder integration with the test bot working, but currently it results in the following when run on Drupal core.
1,044 minor(s), 24 critical(s), and 3,611 normal(s)I would like to remove all critical and normals from Drupal core before enabling coder reviews on qa.drupal.org. Some may be issues with coder itself that need to be fixed, others may be Drupal core issues. I want to reach that threshold so we can enable it, then we can worry about getting rid of minors via patches to core or better detection methods in coder etc.
Comments
#1
Core style review
I will update this with a list of issues:
Core
Coder
#2
Does this issue count under style as well? #606526: [Needs rollback] Remove trailing whitespaces and add newlines at end of files
#3
#4
Adding per axyjo's request in IRC:
#672268: Comment cleanup of includes/database/database.inc
#5
Added link to qa.d.o style review.
#6
Talked with webchick and decided to push for this heavily in early 8.x cycle.
#7
Awesome work, guys!