Download & Extend
Issues

Style cleanup #1

Posted by boombatower on December 22, 2009 at 8:36pm
Project:Drupal core
Version:7.x-dev
Component:base system
Category:task
Priority:normal
Assigned:boombatower
Status:closed (fixed)
Issue tags:coding standards

Issue Summary

#666022: [meta issue] Style cleanup

Login or register to post comments

Comments

#1

Posted by boombatower on December 22, 2009 at 8:48pm
Assigned to:Anonymous» boombatower
Status:active» needs review
AttachmentSizeStatusTest resultOperations
666024-style-cleanup-1.patch14.78 KBIdleFailed on MySQL 5.0 InnoDB, with: 9,837 pass(es), 385 fail(s), and 14 exception(es).View details

#2

Posted by System Message on December 22, 2009 at 9:01pm
Status:needs review» needs work

The last submitted patch failed testing.

#3

Posted by boombatower on December 23, 2009 at 12:25am
Status:needs work» needs review
AttachmentSizeStatusTest resultOperations
666024-style-cleanup-1.patch14.5 KBIdlePassed on all environments.View details

#4

Posted by System Message on December 24, 2009 at 12:21am
Status:needs review» needs work

The last submitted patch, , failed testing.

#5

Posted by System Message on December 24, 2009 at 1:19am
Status:needs work» needs review

Re-test of from comment #2400918 was requested by @user.

#6

Posted by System Message on December 24, 2009 at 7:01am
Status:needs review» needs work

The last submitted patch, , failed testing.

#7

Posted by System Message on December 27, 2009 at 2:34am
Status:needs work» needs review

Re-test of from comment #2400918 was requested by @user.

#9

Posted by mcrittenden on December 29, 2009 at 8:19pm

Looks good on my end. Anybody care to RTBC? Would be good to get this in quickly since re-rolling will be a pain as it touches so many files.

#10

Posted by int on December 29, 2009 at 8:23pm

looks good

#11

Posted by Dave Reid on December 29, 2009 at 8:27pm

+++ includes/bootstrap.inc 23 Dec 2009 00:24:54 -0000
@@ -37,8 +37,9 @@
+ * The item may be remove using cache_clear_all() with a cache ID.

item may be removed

This review is powered by Dreditor.

#12

Posted by Dave Reid on December 29, 2009 at 8:27pm
Status:needs review» needs work

#13

Posted by mcrittenden on December 29, 2009 at 8:29pm
Status:needs work» needs review

#11 fixed here.

AttachmentSizeStatusTest resultOperations
cleanup.patch14.5 KBIdlePassed on all environments.View details

#14

Posted by dawehner on December 29, 2009 at 8:31pm
Status:needs review» needs work

+++ includes/cache-install.inc 23 Dec 2009 00:24:54 -0000
@@ -2,13 +2,18 @@
- * need for any persistent storage. Obviously, using this cache
- * implementation during normal operations would have a negative impact
- * on performance.
+ * @file
+ * Provides a stub cache implementation to be used during installation.

indentation

I'm on crack. Are you, too?

#15

Posted by Dave Reid on December 29, 2009 at 8:34pm
Status:needs work» reviewed & tested by the community

Actually that's valid for @file headers (http://drupal.org/node/1354).

#16

Posted by boombatower on December 29, 2009 at 8:48pm

#17

Posted by Dries on December 30, 2009 at 8:16am
Status:reviewed & tested by the community» fixed

Committed! Thanks all.

#18

Posted by System Message on January 13, 2010 at 8:20am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.