#666022: [meta issue] Style cleanup

CommentFileSizeAuthor
#13 cleanup.patch14.5 KBmcrittenden
#3 666024-style-cleanup-1.patch14.5 KBboombatower
#1 666024-style-cleanup-1.patch14.78 KBboombatower

Comments

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Status: Active » Needs review
StatusFileSize
new 666024-style-cleanup-1.patch14.78 KB

Status: Needs review » Needs work

The last submitted patch failed testing.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
StatusFileSize
new 666024-style-cleanup-1.patch14.5 KB

Status: Needs review » Needs work

The last submitted patch, , failed testing.

Status: Needs work » Needs review

Re-test of from comment #2400918 was requested by @user.

Status: Needs review » Needs work

The last submitted patch, , failed testing.

Status: Needs work » Needs review

Re-test of from comment #2400918 was requested by @user.

mcrittenden’s picture

mcrittenden commented

Looks good on my end. Anybody care to RTBC? Would be good to get this in quickly since re-rolling will be a pain as it touches so many files.

int’s picture

int commented

looks good

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented 
+++ includes/bootstrap.inc	23 Dec 2009 00:24:54 -0000
@@ -37,8 +37,9 @@
+ * The item may be remove using cache_clear_all() with a cache ID.

item may be removed

This review is powered by Dreditor.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Needs work
mcrittenden’s picture

mcrittenden commented
Status: Needs work » Needs review
StatusFileSize
new cleanup.patch14.5 KB

#11 fixed here.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work 
+++ includes/cache-install.inc	23 Dec 2009 00:24:54 -0000
@@ -2,13 +2,18 @@
- * need for any persistent storage. Obviously, using this cache
- * implementation during normal operations would have a negative impact
- * on performance.
+ * @file
+ * Provides a stub cache implementation to be used during installation.

indentation

I'm on crack. Are you, too?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Reviewed & tested by the community

Actually that's valid for @file headers (http://drupal.org/node/1354).

boombatower’s picture

boombatower commented
Issue tags: +Coding standards
dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed! Thanks all.

Status: Fixed » Closed (fixed)
Issue tags: -Coding standards

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Coding standards

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.