Hi,

I've just updated to the latest full release and had the following error at the "Run updates" stage of running update.php;

An unrecoverable error has occurred. You can find the error message below. It is advised to copy it to the clipboard for reference.
Please continue to the error page

An error occurred. http://www.sitename.co.uk/update.php?id=29&op=do <br /> <b>Warning</b>: Call-time pass-by-reference has been deprecated in <b>/var/www/vhosts/sitename.co.uk/httpdocs/sites/all/modules/yahoo_weather_forecast/yahoo_weather_forecast.install</b> on line <b>76</b><br /> { "status": true, "percentage": 100, "message": "Remaining 0 of 1.\x3cbr/\x3eUpdating yahoo_weather_forecast module" }

The following was also generated at the top of the page;

Warning: Call-time pass-by-reference has been deprecated in /var/www/vhosts/sitename.co.uk/httpdocs/sites/all/modules/yahoo_weather_forecast/yahoo_weather_forecast.install on line 76

Any help would be greatly appreciated - many thanks

CommentFileSizeAuthor
#8 509598-yahoo-weather-update.patch2.37 KBPedro Lozano

Comments

axel pressbutton’s picture

axel pressbutton commented

UPDATE:

I've just gone through to the final stage of the update and have more error details;

warning: Invalid argument supplied for foreach() in /var/www/vhosts/sitename.co.uk/httpdocs/includes/database.mysql-common.inc on line 69.
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') /*!40100 DEFAULT CHARACTER SET UTF8 */' at line 2 query: CREATE TABLE yahoo_weather_forecast_blocks ) /*!40100 DEFAULT CHARACTER SET UTF8 */ in /var/www/vhosts/sitename.co.uk/httpdocs/includes/database.inc on line 529.
user warning: Table 'lmfcdb5.yahoo_weather_forecast_blocks' doesn't exist query: INSERT INTO yahoo_weather_forecast_blocks (zip_code, name_city, units, display_options, data) VALUES('12056', 'Bath', 'f', 'a:11:{s:7:\"current\";s:7:\"current\";s:11:\"temperature\";s:11:\"temperature\";s:4:\"wind\";s:4:\"wind\";s:14:\"wind_direction\";s:14:\"wind_direction\";s:10:\"feels_like\";s:10:\"feels_like\";s:10:\"visibility\";s:10:\"visibility\";s:14:\"sunrise_sunset\";s:14:\"sunrise_sunset\";s:8:\"humidity\";i:0;s:8:\"pressure\";i:0;s:8:\"forecast\";i:0;s:20:\"forecast_description\";i:0;}', '') in /var/www/vhosts/sitename.co.uk/httpdocs/sites/all/modules/yahoo_weather_forecast/yahoo_weather_forecast.install on line 86.
user warning: Table 'lmfcdb5.yahoo_weather_forecast_blocks' doesn't exist query: SELECT delta FROM yahoo_weather_forecast_blocks ORDER BY delta DESC LIMIT 1 in /var/www/vhosts/sitename.co.uk/httpdocs/sites/all/modules/yahoo_weather_forecast/yahoo_weather_forecast.install on line 88.
user warning: Table 'lmfcdb5.yahoo_weather_forecast_blocks' doesn't exist query: SELECT zip_code, name_city, units FROM yahoo_weather_forecast_blocks WHERE delta=0 in /var/www/vhosts/sitename.co.uk/httpdocs/sites/all/modules/yahoo_weather_forecast/yahoo_weather_forecast.module on line 509.
user warning: Table 'lmfcdb5.yahoo_weather_forecast_blocks' doesn't exist query: UPDATE yahoo_weather_forecast_blocks SET data = 's:14:\"City not found\";' WHERE delta = 0 in /var/www/vhosts/sitename.co.uk/httpdocs/sites/all/modules/yahoo_weather_forecast/yahoo_weather_forecast.module on line 175.

The following queries were executed
yahoo_weather_forecast module
Update #6000
Failed: CREATE TABLE {yahoo_weather_forecast_blocks} ) /*!40100 DEFAULT CHARACTER SET UTF8 */

Hope this helps

Thanks again

paulbeaney’s picture

paulbeaney commented

+1 My Yahoo Weather module update has just crashed and burned too. The problem is the CREATE TABLE in the update process - it looks like all the fields are missing.

Regards,

- Paul

Pedro Lozano’s picture

Pedro Lozano commented
Status: Active » Postponed (maintainer needs more info)

I've been unable to reproduce this. What PHP version are you using.

Anyway, the update only converts your old config to a block in the new multiblock system. Installing and configuring the module again should work fine.

There certainly is a syntax error in the update that will be corrected in the next version but it has worked fine for me in all my tests.

In anyone has the same problem and can provide more details it will be appreciated.

Pedro Lozano’s picture

Pedro Lozano commented

I've fixed and commited the syntax error in the DRUPAL-6--1 branch. That should fix your fix warning but I'm not sure about the second error.

axel pressbutton’s picture

axel pressbutton commented

Thanks for the prompt response Pedro :)

FYI I'm using PHP 5.29

I'll give the latest version a try later today and let you know how I got on

Pedro Lozano’s picture

Pedro Lozano commented
Status: Postponed (maintainer needs more info) » Needs review

Here is a patch that should work correctly.

Somehow the drupal_get_schema call returns nothing in your updates so the table was not created.

I corrected the previous code but also introduced a new update for those who tryed to update and failed. This new update tries to create the table again if it doesn't exist yet.

Please could you try this patch (or download from cvs DRUPAL-6--1 banch) and tell my if it works well. Thanks.

axel pressbutton’s picture

axel pressbutton commented

I'll try and grab from cvs in the morning as had a really long day driving - there doesn't appear to be a patch attached to your last post :(

Pedro Lozano’s picture

Pedro Lozano commented
StatusFileSize
new 509598-yahoo-weather-update.patch2.37 KB

Sorry, I forgot. Here is the patch.

axel pressbutton’s picture

axel pressbutton commented

Brilliant, Thanks for that Pedro. Sorry for the late response but it's been a bit non-stop here over the last couple of days.

I tried the latest dev version and everything worked, so a big thumbs up!

Thanks again for this module and your continued support.

Pedro Lozano’s picture

Pedro Lozano commented
Status: Needs review » Fixed

Ok. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.