I should have started this when I first began the official rewrite as much of the code in the 6.x-2.x rewrite was inspired by Drupal 7. Now I have to go back and remember why I did things certain ways and adjust for Drupal 7 instead of developing both version concurrently and drawing inspiration from each other.

So begins the long and dangerous journey of porting a huge module to Drupal 7...

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

This will update with the current progress

What currently works:
- Enabling and basic administration on the xmlsitemap.module and xmlsitemap_engines.module
- Generating and displaying sitemap data
- xmlsitemap_custom 100% working
- Basic xmlsitemap_node functionality

What doesn't work (aka in progress):
- Rebuilding sitemap
- xmlsitemap_menu
- xmlsitemap_taxonomy

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Also, we are the first module to try out automatic patch testing since we now have a Drupal 7 branch. This should help motivate a fire on my ass to get the tests in proper shape.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Issue tags: +D7CX
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: Port the module to Drupal 7 » XML sitemap Drupal 7 port
BenK’s picture

BenK commented

Subscribing...

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Update that xmlsitemap_custom is 100% working, xmlsitemap_node now has basic functionality (working out some bugs when trying to override individual node inclusion/priority).

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

xmlsitemap_taxonomy is now 90% working and batch rebuilding works just great!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Fixed

The xmlsitemap_menu module now works as expected. I think the 6.x-2.x and 7.x-2.x versions are fully equal now (aside from xmlsitemap_i18n which hasn't been ported to D7). I'm going to mark this as fixed since I'm going to roll out an 7.x-2.0-alpha1 along with 6.x-2.0-alpha1.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

atchijov’s picture

atchijov commented

I think there is a problem with D7 port, though I am not sure if it is problem with xmlsitemap or Drupal core.
Basically in D7-Alpha5, hook_menu_update is not going to be called if you just change xmlsitemap settings. You have to change one of "standard" menu fields (like description) to make hook work.

atchijov’s picture

atchijov commented
Status: Closed (fixed) » Active

I guess I have to make it active to make sure that my comment was read.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Fixed

Yes it's a core bug waiting for some review: #801894: SAVED_UPDATED is not always SAVED_UPDATED.

atchijov’s picture

atchijov commented
Status: Fixed » Closed (fixed)

sorry that I tried to pin it on xmlsitemap :)

other then that issue, works like a champ on our site (www.touchnoc.com D7 alpha5+)

David Latapie’s picture

David Latapie commented
Component: Code » xmlsitemap.module
Category: task » bug
Priority: Normal » Critical
Status: Closed (fixed) » Needs work

"The website encountered an unexpected error. Please try again later" when using XML sitemap dev for D7 (I tried with the alpha version of the module before). I reduced the testcase by only enabling the core module, xmlsitemaps (i.e.: not the the submodules).

I am using Drupal 7 RC3.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Component: xmlsitemap.module » Code
Category: bug » task
Priority: Critical » Normal
Status: Needs work » Closed (fixed)

Please file an issue rather than opening an unrelated issue.