So let's make them.

CommentFileSizeAuthor
buttons_container.patch443 byteschx

Comments

Status: Needs review » Needs work

The last submitted patch, , failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review

My bad.

Re-test of buttons_container.patch from comment @comment was requested by casey.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

So.. what does this do?

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs review

I'm with webchick ... it is not entirely clear what bug we're fixing here. Let's get some clarification.

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented
Title: node form buttons is not a container » node form buttons is not a container - we need a wrapper around buttons
Category: bug » feature
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

This is a most welcomed patch that will make it a lot easier to theme the form buttons as a group in their own container.

Before this patch, for example the node creation form, the Submit and Preview button are displayed inline without any grouping container:

<input type="submit" class="form-submit" value="Save" id="edit-submit" name="op">
<input type="submit" class="form-submit" value="Preview" id="edit-preview" name="op">

Once this patch is applied, through the form API, a container is added around the form buttons:

<div class="form-wrapper" id="buttons-wrapper">
  <input type="submit" class="form-submit" value="Save" id="edit-submit" name="op">
  <input type="submit" class="form-submit" value="Preview" id="edit-preview" name="op">
</div>

This is best-practice and not necessarily a bug, but rather an oversight. Marking this as a feature request instead.

moshe weitzman’s picture

moshe weitzman commented

If you care to see the code that runs for #container elements, see

http://api.drupal.org/api/function/theme_container/7
http://api.drupal.org/api/function/form_process_container/7

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Thanks for the explanation. That helps. Committed to CVS HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.