When I click the more authors button on a create biblio content form, I get the AJAX working icon but nothing else happens. By default, I'm getting 4 authors fields and I don't see where, as a workaround, I can increase that.

Screenshot is attached, which just shows the icon next to More Authors.

I'm happy to give you admin access to my dev server to see the issue. Thanks!

CommentFileSizeAuthor
Picture 2.png163.54 KBdankohn

Comments

rjerome’s picture

This is an ongoing issue with Drupal core, which was supposed to be fixed in 6.15 but I see that they didn't, rather just removed the 6.15 release blocker tag on the issue and left it unfixed :-(

I guess I'll have to see if there is anything I can do. In the mean time you can change the default ($contributor_count) in the _biblio_contributor_widget() function located in the biblio.module file, see below...

function _biblio_contributor_widget($node, $fld, $auth_category, $biblio_type, $other_fieldset = FALSE) {
  $fldname = $fld['name'];
  $type = str_replace('_', '-', $fldname);
  if (is_object($node)) {
    $contributors = (array) $node->biblio_contributors[$auth_category];
  }
  else {
    $contributors = $node['biblio_contributors'][$auth_category];
  }

  $contributor_count = max(4, count($contributors));                     // <--- default currently set to 4

  $ctypes = _biblio_get_auth_types($auth_category, $biblio_type);
  // if no author types are available skip this widget
  if (!isset($ctypes)) return array();
  $ctypes = db_query('SELECT * FROM {biblio_contributor_type_data}
                      WHERE auth_type IN ('. implode(',', $ctypes) .')');
  while ($ctype = db_fetch_object($ctypes)) {
    $options[$ctype->auth_type] = $ctype->title;
  }

....

dankohn’s picture

Thanks for the quick response and workaround. Much appreciated.

dankohn’s picture

Until core is fixed, you might consider making the default number of authors a configurable variable in the admin UI.

rjerome’s picture

Good idea.

BTW, I got the email regarding your website, but I haven't had a chance to review it yet. Maybe over the holidays.

Ron.

dankohn’s picture

Version: 6.x-1.9 » 6.x-1.14

rjerome, would you mind checking out this bug again? I just had to reapply the workaround. If you can link to the underlying core bug, I can add a ping there asking for it to get fixed.

If it doesn't look like it will be, it might be worth making $max_contributor_count a variable that can be set in the UI.

Thanks.

rjerome’s picture

I've just applied the fix in http://drupal.org/node/591696#comment-2619548 to the -dev version. I can't reproduce this issue, so I don't really know if it fixed the issue.

http://drupal.org/cvs?commit=411290

astreib’s picture

The release notes for 6x-1.15 claim that this is fixed, but I still have the problem in Safari and Firefox at least.

EDIT: Oops, I see in the first comment that it's NOT fixed in 6x-1.15. The release notes imply that it is, as this issue is listed under "Bugs Fixed".

dankohn’s picture

Version: 6.x-1.14 » 6.x-1.15

I can confirm it's not fixed in 1.15.

rjerome, I'm happy to give you an admin account on a dev server if you're unable to replicate the problem on your setup.

Also, please note that comment 30 here seems to offer a simpler solution: http://drupal.org/node/591696#comment-3369036

Thanks.

javier1968’s picture

Exactly the same problem here although it only seems to happen on IE but not on Safari or Firefox.

Cheers

rjerome’s picture

Ahhh, that's a useful bit of information, I'm not sure I ever tested it with IE.

Ron.

liam morland’s picture

Issue summary: View changes
Status: Active » Closed (outdated)

This version is no longer maintained. If this issue is still relevant to the Drupal 7 version, please re-open and provide details.