Closed (fixed)
Project:
Views (for Drupal 7)
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Dec 2009 at 16:57 UTC
Updated:
6 Feb 2010 at 15:39 UTC
This is a follow up of: #652812: get_count_optimized & has_aggregate undefined in views_plugin_query_default.inc
I wrote another test that fails. The problem is that 652812 only check if has_aggregate is setted to TRUE when fields are analysed, however in views that doesn't display COUNT, SUM, MAX, etc in the SELECT statement like this simple query:
SELECT type
FROM node
GROUP BY type
HAVING COUNT(nid) > 3
GROUP BY and HAVING are not added.
Patch with the new GROUP BY test and patch to fix this bug are attached.
| Comment | File | Size | Author |
|---|---|---|---|
| views-group-by-more-tests.patch | 3.88 KB | dagmar | |
| views-group-by-fix.patch | 1.24 KB | dagmar |
Comments
Comment #1
dagmarTagging
Comment #2
dawehnerworks fine.
It would be cool if the tests would be committed too.
Comment #3
merlinofchaos commentedCommitted to 6.x-3.x, with test.
Comment #4
dawehnerThats already part of the group-by-d7 patch
Comment #5
dawehnerremove tag