SQL error

I appear to be having the same issue with revisioning 3.3 version. When viewing revisions tab e.g. path: page/200/revisions I get the following errors:

* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'revisions >=1' at line 1 query: SELECT COUNT(*) FROM node_access WHERE (nid=0 OR nid=200) AND ((gid=0 AND realm='all') OR ((gid=2 AND realm='workflow_access') OR (gid=3 AND realm='workflow_access_owner'))) AND grant_view revisions >=1 in ... .../module_grants/module_grants.module on line 259.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'revisions >=1' at line 1 query: SELECT COUNT(*) FROM node_access WHERE (nid=0 OR nid=200) AND ((gid=0 AND realm='all') OR ((gid=2 AND realm='workflow_access') OR (gid=3 AND realm='workflow_access_owner'))) AND grant_view revisions >=1 in ... .../module_grants/module_grants.module on line 259.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'revisions >=1' at line 1 query: SELECT COUNT(*) FROM node_access WHERE (nid=0 OR nid=200) AND ((gid=0 AND realm='all') OR ((gid=2 AND realm='workflow_access') OR (gid=3 AND realm='workflow_access_owner'))) AND grant_edit revisions >=1 in ... .../module_grants/module_grants.module on line 259.

Still getting my head around this, probably old news to you, but line 259 is not that helpful, looking at line 255 in module_grants.module:

$sql = $base_sql . (empty($module_grants) ? "" : " OR ($module_grants)") .") AND grant_$op >=1";

It is using $op so I'm guessing its trying to concatenate values of $op that contain white space such as 'view revisions', 'edit current' etc hence the sql errors. Node access columns need to be one of grant_view, grant_update or grant_delete (hence why the previous fix to single word 'update' appeared to work). RdeBoer you mentioned that the conversion to the correct grant op should have occurred in function _revision_tasks_menu_access_callback, but looking at revisioning module I couldn't find a matching access callback for node/node%/revisioning... not sure if that is relevant?

My statement above possibly is irrelevant as I'm also getting sql errors plus others when viewing path: page/200/revisions/50/view

* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'revisions >=1' at line 1 query: SELECT COUNT(*) FROM node_access WHERE (nid=0 OR nid=200) AND ((gid=0 AND realm='all') OR ((gid=2 AND realm='workflow_access') OR (gid=3 AND realm='workflow_access_owner'))) AND grant_view revisions >=1 in ... .../module_grants/module_grants.module on line 259.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'revisions >=1' at line 1 query: SELECT COUNT(*) FROM node_access WHERE (nid=0 OR nid=200) AND ((gid=0 AND realm='all') OR ((gid=2 AND realm='workflow_access') OR (gid=3 AND realm='workflow_access_owner'))) AND grant_edit revisions >=1 in ... .../module_grants/module_grants.module on line 259.
* warning: Missing argument 1 for node_page_view() in ... .../node/node.module on line 1783.
* warning: Invalid argument supplied for foreach() in ... .../cck/content.module on line 1284.

Looking into it a bit more I see the difficulty. I can't find anywhere in my modules where module_grants_node_access is called with anything other than 'view', 'update' or 'delete' as the op. Yet if I put dpm($op) at the top of the function I get:

* view
* Published page Some Page has 3 revisions.
* delete
* view revisions
* view
* view
* view revisions
* view
* edit revisions
* view

Yep Module Grants 6.x-3.3 and Revisioning 6.x-3.3:
; $Id: revisioning.info,v 1.12 2010/01/03 06:57:11 rdeboer Exp $
; $Id: module_grants.info,v 1.7 2009/12/16 03:40:11 rdeboer Exp $

Have gone to Administer >> Site building >> Modules page and pressed Save configuration.
Emptied cache (using devel).
Rebuilt menus (using devel).

Still getting error. If it helps troubleshoot, when I simply view path node/200 I also get the error:

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'revisions >=1' at line 1 query: SELECT COUNT(*) FROM node_access WHERE (nid=0 OR nid=200) AND ((gid=0 AND realm='all') OR ((gid=2 AND realm='workflow_access') OR (gid=3 AND realm='workflow_access_owner'))) AND grant_view revisions >=1 in ... .../module_grants/module_grants.module on line 260.

Perhaps more useful:
// $Id: module_grants.module,v 1.47 2010/01/04 23:52:20 rdeboer Exp $
// $Id: revisioning.module,v 1.69 2010/01/07 04:10:00 rdeboer Exp $

Since I can't track the source of 'view revisions' being passed as $op in module_grants_node_access, would it makes sense to do a temp fix by putting something like this at the top of the module_grants_node_access function:

switch ($op) {
    case 'view revisions':
      return _user_may_view_revisions($node);
      break;
  }

Or rather:

switch ($op) {
    case 'view revisions':
    case 'edit revisions':
      return module_grants_node_revision_access($op, $node);
      break;
  }

Doesn't address other errors when viewing a revision:

* warning: Missing argument 1 for node_page_view() in ... .../node/node.module on line 1783.
* warning: Invalid argument supplied for foreach() in ... .../cck/content.module on line 1284.

First seems to want cid (comment id?). Latter is returning empty array. Not sure about these errors, going to revert back to earlier versions of Module Grants and Revisioning to make sure errors are result of upgrade.

To follow up. No errors after reverting back to Revisioning 6.x-2.3 and Module Grants 6.x-2.x-dev.

Just installed Revisioning 6.x-3.4 and Module Grants 6.x-3.4. Still receiving the SQL errors above, i.e. 'grant_view revisions' and 'grant_edit revisions' appearing when trying to view an existing revision. And the 'Missing argument...' and 'Invalid argument...' errors. Any ideas?

The non SQL errors are possibly Revisioning module issue? From what I can tell, the page callback for e.g. /node/200/revisions/10 is node_page_view, not _revision_view. Is that correct? From looking at revisioning.module it seems it should be _revision_view. Looking at menu router table I see:

+---------------------------------+-----------------+
| path                            | page_callback   |
+---------------------------------+-----------------+
| admin/settings/revisioning      | drupal_get_form | 
| admin/help/revisioning          | help_page       | 
| node/%/revisions                | _present_node   | 
| node/%/revisions/list           | _present_node   | 
| admin/build/trigger/revisioning | trigger_assign  | 
| node/%/revisions/%/delete       | _present_node   | 
| node/%/revisions/%/revert       | _present_node   | 
| node/%/revisions/%/view         | node_page_view  | 
| node/%/revisions/%/publish      | drupal_get_form | 
| node/%/revisions/%/unpublish    | drupal_get_form | 
| node/%/revisions/%/edit         | _revision_edit  | 
+---------------------------------+-----------------+

Not sure if that is relevant? It seems node_page_view is missing a $node.

So it seems Module Grants line 49 is controlling the page_callback, and isn't assigning any page arguments. If I add:
$items['node/%node/revisions/%/view']['page arguments'] = array(1); to line 50 of Module Grants and rebuild the menus it fixes the following errors:

warning: Missing argument 1 for node_page_view() in .../modules/node/node.module on line 1783.
warning: Invalid argument supplied for foreach() in .../sites/example.com/modules/contributed/cck/content.module on line 1284.

But I'm not sure if that is an actual fix. It seems the page callback should be _revision_view, from revisioning module, not node_page_view from module grants?

So upon checking the weight of my modules in the system table I discovered that module_grants was set as a heavier weight than revisioning. I can't find anywhere in module_grants module where it suggests this is intentional, so I suspect it was done manually on our db at some point in the past, possibly to address conflicts with og_access which has a weight of 1. So I changed the weights to ensure revisioning was heavier than module grants, emptied cache and rebuilt menus and it appears to have fixed both the page callback errors and the SQL errors regarding 'grant_view revisions'. Fingers crossed that was all it was.

Yes, solved. All errors appear to have been addressed.