patch attached

CommentFileSizeAuthor
#7 667504-link-node-title.patch2.12 KBmerlinofchaos
#6 link_title_better.patch1.62 KBjenlampton
#5 link_title.patch1.62 KBjenlampton
#2 title_linked.patch1.55 KBjenlampton
title_link.patch1.51 KBjenlampton

Comments

summit’s picture

summit commented

Subscribing, great flexibility for pane title! greetings, Martijn

jenlampton’s picture

jenlampton
she / her
commented
Version: 6.x-1.2 » 6.x-1.6
StatusFileSize
new title_linked.patch1.55 KB

Looks like you haven't gotten to this yet, but I still need it. So here's a new patch re-rolled against the dev branch. :-)

merlinofchaos’s picture

merlinofchaos commented
Status: Active » Needs review

Changing status, this will help.

merlinofchaos’s picture

merlinofchaos commented

Two quick comments:

Need to use empty() on the $conf test because pre-existing node content will not have that setting.
We use the D7 code style for the . operator which means it should have spaces around it.

jenlampton’s picture

jenlampton
she / her
commented
StatusFileSize
new link_title.patch1.62 KB

okie dokey.

jenlampton’s picture

jenlampton
she / her
commented
StatusFileSize
new link_title_better.patch1.62 KB

default should be zero if conf is empty.

merlinofchaos’s picture

merlinofchaos commented
Version: 6.x-1.6 » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)
StatusFileSize
new 667504-link-node-title.patch2.12 KB

Actual patch committed is attached.

merlinofchaos’s picture

merlinofchaos commented
Status: Patch (to be ported) » Closed (fixed)

All of the 'to be ported' patches got merged in during the porting sprint in September.