Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.For the admin/settings/opensearch page, we should use the 'administer search' permission provided by search.module instead of the way-too-general 'administer site configuration'.
Comments
Comment #1
avpadernoWould to move the settings page inside the search settings page make sense? I think that most users would look into that page, when searching for the module settings (IMO); then, it would reduce the code that should not even implement
hook_menu().The con is that in this case it would not be possible to put the administration code into a separate file.
Comment #2
dave reidProbably what would be best to create it as a local task under admin/settings/search. Make the search.module settings a default local task named 'Settings'.
Comment #3
dave reidSeems the permission change slipped in with my coding cleanup patch, so I'm going to change this to cover the settings (and where the settings should be) retooling and revamping.
Comment #4
dave reidThis issue would also encompass:
#667632: Use token for variable replacement instead of @placeholders
#663356: Choose what search hook should be opensearched
Comment #5
avpadernoThere are some form fields that accepts more than 64 characters, and they are textfields; it would be better to make them textareas.
Comment #6
avpaderno#668708: Provide settings for each search page replaces #663356: Choose what search hook should be opensearched.
Comment #7
avpadernoI have moved the settings page under /admin/settings/search/opensearch, and added a menu callback to make the search settings page added from search.module the default tab.
Comment #8
avpadernoI changed the textfield form fields in textarea form fields. This has been done in consideration of a possible introduction of a new feature that would allow to execute PHP code.
Comment #9
avpadernoThe code has been changed, and committed in CVS.
Comment #10
dave reidNice work!