- Coding standards fixes
- Redundant check_plain()'s and t()'s
- Use module_implements() instead of module_list() and module_hook() double loops

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

If you think it is better, we could first change the part that returns the output of the module, so the changes I have done could be committed.

As alternative, I can re-undo all the changes, and we can start from the beginning again.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I think the theme-related part of the patch should be a separate issue that would be best committed after the code files have been split up so they can go in opensearch.pages.inc.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

I have put away the code I was starting to develop, and I restored the code from CVS. I re-ordered the code, and added some documentation comments.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Fixed

Committed initial clean-up and now working on the code split. There's a lot more clean-ups that will be fixed along the way.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.