For better code use, we should just depend and integrate with token.module. Replacements like '@type search for @site.' done in t() (not a good way to do this kind of replacement either) could be '[search-type] search for [site-name]'. This offers a lot more flexibility for end-users.
Again, to be clear, this would add a dependency on token.module. Maybe if we don't want there to be a dependency we can only expose the text-replacement options if token module is enabled.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 667632-opensearch-token-D6.patch | 1.78 KB | dave reid |
| #2 | 667632-opensearch-token-D6.patch | 979 bytes | dave reid |
Comments
Comment #1
avpadernoConsidering that token.module is included in Drupal 7, I think that changing the code to use token.module would be something desirable. To have a dependency on token.module should not be something negative, IMO.
Comment #2
dave reidHere's what the actual token implementations would look like, but would need to actually use the token functions when the strings are used.
Comment #3
dave reidQuick improvement that adds the current search module and keywords tokens.
Comment #4
avpadernoThe code has been changed, and committed in CVS.