When you toggle the admin sidebar, it animates smoothly, but the body contents get immediate padding change, which is not good. My patch adds animation to body too.

Patch also fixes glitch caused by #652744: Admin in Opera 10 when admin buttons stays visible after closing the pane.

Thanks.

CommentFileSizeAuthor
#4 00-admin-vert-right-closed.png85.16 KBemptyvoid
#4 01-admin-vert-right-open.png85.51 KBemptyvoid
#2 admin-smooth.patch2.87 KBneochief
admin-smooth.patch1.66 KBneochief

Comments

gooddesignusa’s picture

gooddesignusa commented

Tried to run this patch and it failed.
patching file admin.toolbar.css
Hunk #1 FAILED at 171.
patching file admin.toolbar.js
Hunk #1 FAILED at 101.
Just letting you know

neochief’s picture

neochief commented
StatusFileSize
new admin-smooth.patch2.87 KB

Sorry, I had to update my working copy to latest dev. Anyways, problem is still there. Here's updated patch.

yhahn’s picture

yhahn commented
Status: Needs review » Fixed

Great, committed: http://drupal.org/cvs?commit=310802

emptyvoid’s picture

emptyvoid commented
Status: Fixed » Needs work
StatusFileSize
new 01-admin-vert-right-open.png85.51 KB
new 00-admin-vert-right-closed.png85.16 KB

The recent patch causes funny actions to occur with any theme. If the menu is set to vertical top right or bottom right the body of the theme will animate on the left side instead of the right.

Issue occurs on:
Firefox 3.5 on windows vista
Internet Explorer 8 on vista

Screen shots attached.

yhahn’s picture

yhahn commented

Yeah, my bad. Should be fixed with http://drupal.org/cvs?commit=311828

I will let you set to fixed this time : P

neochief’s picture

neochief commented

Sorry, it's my bad initially. Thankfully the fix is pretty easy.

yhahn’s picture

yhahn commented
Status: Needs work » Closed (fixed)

Closing.