IE 6 shows elements with position:fixed as position:static. Currently we made it look right again by removing the padding-top from body.

But toolbar needs it's z-index to stay above overlay. position:static does not use z-index. Therefor we should use position:absolute for #toolbar in IE6 instead of removing the padding-top from body.

CommentFileSizeAuthor
#3 after_overlay.png32.83 KBcasey
#3 before_overlay.png32.56 KBcasey
#3 after.png24.63 KBcasey
#3 before.png24.52 KBcasey
overlaytoolbarIE6.patch794 bytescasey

Comments

kiphaas7’s picture

kiphaas7 commented
Component: overlay.module » toolbar.module

Since this is a patch against toolbar, shouldn't it belong there?

casey’s picture

casey commented
Priority: Normal » Critical
StatusFileSize
new before.png24.52 KB
new after.png24.63 KB
new before_overlay.png32.56 KB
new after_overlay.png32.83 KB

Critical for IE6 users :p

aspilicious’s picture

aspilicious commented

Looks much better, IE6 is such a crappy browser, everything looks crappy anyway...

im confused with the code

* html #toolbar {
    position: absolute;
    top: 0;
    left: 0;
 }

is this the IE6 only hack you were talking about (the * html)

casey’s picture

casey commented

http://www.webdevout.net/css-hacks#in_css-selectors

Yes, It's one of the few CSS valid hacks. And newer browsers aren't going to support this as the html element doesn't have a parent. Perfect hack.

As you see this hack is used now too.

I can have a look at other things looking crappy in IE6 later. This one is RTBC?

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Can i ask what you use to test IE6?
I used IEtester in the past but that one doesnt work on my windows 7 64 bit operating system.

And as this i an IE6 only affecting style thing, and it works in IE6 then i guess it is RTBC.

casey’s picture

casey commented

http://finalbuilds.edskes.net/iecollection.htm on winXP

aspilicious’s picture

aspilicious commented

doesn't work either
windows 7 hates IE6 i guess :D

CalebD’s picture

CalebD commented

Microsoft has a Virtual Hard Disk available of Windows XP SP3 with IE6 installed. You can use Virtual PC 2007 with the VHD to test IE6.

VHDs: http://www.microsoft.com/downloads/details.aspx?FamilyID=21eabb90-958f-4...
Virtual PC: http://www.microsoft.com/downloads/details.aspx?FamilyId=04D26402-3199-4...

If you're on a non Windows OS, you might be able to convert the VHDs to another format, but I'm not sure if that is acceptable under the terms of using the VHD files.

aspilicious’s picture

aspilicious commented

Ok but thats only a minor issue here, review this thing so it will be rtbc ;)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Commited to CVS HEAD. It isn't 100% clear whether this is RTBC, but it sounds like it is. Unfortunately, I don't have IE6 so I can't really verify it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.