CVS edit link for Zarevac

I have been templating for a decade now and have been contributing to Open Source projects for some time now. But now I decided I want to go one step further and put the experience in templating to contribute it to the community. As I am a big Zen fan I created a template that is under construction @ h2osolutions.org, its the template the site is using and I want this one and other sub-Zen templates to be availible for the Drupal community and the OS community as a whole.

Besides Drupal I am also a contributed to the Phorum project.

Because I do commercial work as well I more and more make suggestions to companies to let designs, modules and other work to become GNU so I can get the price lower and give something back to the community.

CommentFileSizeAuthor
#9 h_o_h.zip126.18 KBZarevac
#7 h_o_h.zip105.4 KBZarevac
#3 h_o_h.zip109.68 KBZarevac
#1 h_o_h.zip57.52 KBZarevac

Comments

Zarevac’s picture

Zarevac commented
StatusFileSize
new h_o_h.zip57.52 KB

Zip file with first version of template.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Postponed (maintainer needs more info) » Needs work

The file template.php doesn't contain any executable code; the file is then not necessary.
The name of the theme is not the name of the author of the theme, and the description should describe the theme, rather than saying which web site is using it.
The files should be cleaned up from comments that are not necessary; those comments have just the purpose of helping to create a sub-theme from the general template given from the theme Zen; once the sub-theme has been created, they should be removed.

Zarevac’s picture

Zarevac commented
StatusFileSize
new h_o_h.zip109.68 KB

Edited the info file and adjusted some info, however after checking out other Zen subthemes I noticed they all left the comments. as this theme isn't stable yet I will clean up these comments then, the template file will soon have more in there. Attached the new zip file.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

See what reported in Apply for contributions CVS access:

Many people write good motivation messages and then mess it up right at the end with "here's a link to my contribution, it's about 75% done". Please, when applying for a CVS account supply a link to your contribution that you believe is complete. Attempting to review uncompleted work is difficult and time consuming (yes, remove all those dpr() and self reminder comments ;) Reviewing completed work is much simpler as there is already a level of expectation in the reviewer. Try to make our job of reviewing your work a joy.

Zarevac’s picture

Zarevac commented

True but stop using double standards. Just checked the other Zen templates and they do the same as I do.....

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Just checked the other Zen templates and they do the same as I do…..

What a user does after he got a CVS account is not something that who approves the CVS application can control; then it is not said that the theme you saw has been used for a CVS application.
If you would have checked other CVS applications, you would have noted that I reported the same thing to another Zen sub-theme.

I don't apply two standards.

Zarevac’s picture

Zarevac commented
StatusFileSize
new h_o_h.zip105.4 KB

then it is not said that the theme you saw has been used for a CVS application.

Actually its themes, but I understand.

Ok I removed the "redundant" tags but not all of them as they do serve a purpose. So please find attached the last try, unlike perhaps others I do not intend to go into lip-service by saying that I cleaned it up to put it back in after I get a CVS account.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +Theme review

I am adding the review tags.

Zarevac’s picture

Zarevac commented
StatusFileSize
new h_o_h.zip126.18 KB

Newer version without comments etc.

Zarevac’s picture

Zarevac commented

Any feedback?

Zarevac’s picture

Zarevac commented

AFAIK I made all the required changes. Please let me know if you are in the mood to react or not.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review

Remember to change the status, when you upload new code.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Closed (won't fix)

See Apply for contributions CVS access before to apply for a CVS account.