checkout procedure blocked [#668258]

Hi,

Drupal 6.15 + ubercart 6.x-2.2 + uc_hotel-6.x-1.0-beta 2

I am testing uc_hotel. Everything was working well during the booking procedure until the stage of review order: book this room -> add addon selections -> checkout .

Here I should click on either cancel or review order. But neither of the 2 links work. I've changed the booking settings, nothing works.

I tried the checkout procedure with a normal ubercart product and it worked. So I think the problem is due to the booking system.

Does someone here get the same problem? Or can you give me a hand? Thanks in advance for your reply.

Comment	File	Size	Author
#10	668258-checkout.patch	10.99 KB	willvincent
	uc_hotel_buttons-no-reaction.jpg	88.19 KB	danny1997

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

willvincent CreditAttribution: willvincent commented 26 December 2009 at 18:32

Category:

bug

» support

What browser are you using?

Does it work if you don't add any upgrades?

What other ubercart related modules do you have installed?

I haven't experienced this behavior in any browser using the same versions of drupal & ubercart...

Comment #2

danny1997 CreditAttribution: danny1997 commented 26 December 2009 at 18:43

Hi tcindie,

Thanks for your prompt reply.

I was using firefox and IE for testing and it was blocked.

But just now I changed and tried it with chrome. It worked !!!! I think it is due to the browser problem. I will do more tests and come back later.

Thanks again.

Comment #3

willvincent CreditAttribution: willvincent commented 26 December 2009 at 18:53

I haven't done a lot of testing in IE, so I'd be willing to accept that as a possible issue...

It certainly works just fine for me in Firefox.

Please keep me posted on any insight you may find. There isn't anything the hotel module is doing on the checkout page that would cause the form to not be able to be submit that I'm aware of. I think something else is going on here.

Comment #4

danny1997 CreditAttribution: danny1997 commented 26 December 2009 at 21:08

tcindie,

I am redoing the same tests with firefox, IE and chrome again.

1. for Hotel booking

The checkout procedure is blocked just with IE 8, not with firefox or chrome. Under IE, with or without the addon / upgrades options, the 2 buttons of cancel / review just don't work (no reactions after the clicks).

I installed only the standard ubercart module and uc-hotel. Nothing else.

I have tested with 3 different themes and the results are the same : OK with firefox and chrome, but blocked with IE.

2. for normal ubercart product

I tried another test with IE just for buying a normal product (not hotel booking), the procedure works well and I can go through the complete checkout process.

It is really strange. I can't figure out why. If you need more infomation about the testing environment, just let me know.

Comment #5

weblance CreditAttribution: weblance commented 27 December 2009 at 17:44

Nice catch Danny, I have tested this and I am experiencing the same bug.

Drupal 6.15 + ubercart 6.x-2.2 + uc_hotel-6.x-1.0-beta 2

i.e. 8.0.6001

Comment #6

danny1997 CreditAttribution: danny1997 commented 27 December 2009 at 18:09

Hi Jeffwilliams,

I am glad to know that it's not due to my owm site configuration or my computor. I just couldn't believe my eyes when I saw the checkout process being blocked like it, and this situation nobody had encountered before me!!!

I have tried all day long to solve the probleme, but ....

Comment #7

willvincent CreditAttribution: willvincent commented 27 December 2009 at 18:13

Component:	User interface	» Code
Assigned:	Unassigned	» willvincent
Category:	support	» bug
Priority:	Normal	» Critical

It might be an issue with how the cart/checkout/order panes are implemented...

I'll take a closer look at this this week and see what I can work out.

Comment #8

willvincent CreditAttribution: willvincent commented 28 December 2009 at 15:32

My suspicion was correct, it looks like there is an issue with how the panes are implemented that causes the checkout page to break in IE... I'll try to get this fixed today.

Comment #9

willvincent CreditAttribution: willvincent commented 30 December 2009 at 21:17

Quick update for everyone,

I have tracked down the specific cause of this issue.

The booking details is being added as a separate form element, rather than just information in a fieldset like regular panes are added.

Looking into how to fix this now. I should have the fix completed within the next few days if not sooner.

Comment #10

willvincent CreditAttribution: willvincent commented 31 December 2009 at 06:14

File	Size
668258-checkout.patch	10.99 KB

The attached patch fixes this issue, as well as another minor issue I discovered while fixing this that was causing the teaser to always be displayed in cart and checkout booking details panes regardless of what was configured through the hotel settings.

I have also commit this to cvs.