We put in a definition of various hook_requirements constants in apachesolr.admin.inc, however when testing on Drupal-6 CVS HEAD, I see a bunch of notices about the contants already being defined.

A little tracing shows that update_help() loads install.inc on every admin page for users with 'administer site configuraiton' permission. blah!

CommentFileSizeAuthor
#1 install-notices-668396-1.patch930 bytespwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new install-notices-668396-1.patch930 bytes
robertdouglass’s picture

robertdouglass commented

But update.module isn't a required module. What happens if you turn it off?

pwolanin’s picture

pwolanin commented

That's ok, this patch does an include_once, so it's not re-included by update module whether or not it's enabled.

robertdouglass’s picture

robertdouglass commented
Status: Needs review » Reviewed & tested by the community

Ok. True. +1 to simpler code.

pwolanin’s picture

pwolanin commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

note that this is almost back to the initial patch at #655006: PHP notices around constants, but Scott didn't dig deep enough to see that he needed to use include_once rather than require_once (which PHP stupidly treats as different).

committed to 6.x-1.x

#668396 by pwolanin, closer to fix from #655006 for PHP notices.
robertdouglass’s picture

robertdouglass commented
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.