Needs work
Project:
Index
Version:
6.x-1.x-dev
Component:
Data types
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
27 Dec 2009 at 02:03 UTC
Updated:
23 Jul 2013 at 23:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
xanoI already had plans for adding filters to entity types, but there just was no issue yet. I can assure you this issue will get fixed before the final.
Comment #2
klonosthanx Xano, once this is implemented all my major issues with what this module is not able to do just yet will be solved. After that, I guess it'll be some minor things here and there.
good work, keep it up and let us know if we can help.
Comment #3
xanoThis is just a first stab at adding filters. They can be defined for every entity type in hook_index_entity_type_info(). Currently only boolean filters and (select) lists are supported, meaning you can either enable or disable a filter or choose values from a select list. Some notes:
- I will have to create a separate page for each filter, because they depend on a layer's entity type, which may change while a user is configuring an index. We cannot simply display the filters from the first page load. Of course AJAX support will be added later.
- The 'value' column in {index_filter} currently is varchar. This means there might be problems when matching it against an integer column when filtering.
Comment #4
xanoFollow-up, including a new icon.
Comment #5
xanoFollow-up.
Comment #6
xanoThe UI sucks and needs to be redesigned.
Comment #7
xanoThe filter buttons are on the right. We need a place to put the filters. I can't find anything suitable within the table. I've been thinking about some kind of overlay or to theme the layer selectors in a totally different way without using a table.
Comment #8
xanoHere's the filter icon in its disabled state.
Comment #9
dgastudio commentedGreat job Xano, thank you very much.
Please, tell me, are u going to include this feature in the next dev build?
Comment #10
xanoI don't know about the next dev build (they're automatically generated every twelve hours, provided the code has been changed), but it will definitely get in before the release.
Comment #11
dgastudio commentedok, so i'll wait to the release.
Comment #12
klonos@Xano: is the 4th patch a cumulative one, or do we need to apply all the previous ones in order?
Comment #13
xanoIt's the result of all previous patches and extra development.
Comment #14
dgastudio commentedcan't apply this patches on build from 2010-Jan-17. can somybody upload already patched files?
thanks
Comment #15
xanoCode changes have been made since the patch was created, so the patch doesn't apply anymore. You can apply the chunks that fail manually if you know how.
Comment #16
klonos@Xano: Can we please have this in the dev builds? Pretty please?
Comment #17
xanoIt's done when it's done. This means you gotta sit back and wait patiently or give me a helping hand to fix the problem. Dev means not ready for production use ;-)
This is a hobby, which means I am not obliged to do anything and are free to enjoy my spare time by doing something else than coding. And I take that very literally, even though I want to see this project finished as much as you do.
I need to revamp the interface and underlying code before filters can get in. I expect this will take a couple of weeks. My intentions are to make whatever features already exists rock solid before adding new stuff. This has worked out pretty good so far, but it does delay new stuff a bit.
Comment #18
jrstmartin commentedLooking forward to filters!
Comment #19
xanoAdding the possibility for storing filter information is being moved to #735164: Conditions API. This issue will deal with the UI and some entity-specific filters.
Comment #20
colanSubscribing.
Comment #21
jvieille commentedSubscribing
Comment #22
momper commentedsub
Comment #23
xano