While working on a D7 theme, my server threw an error message (a typical mySQL error that I've been getting from my server, having nothing to do with D7). Because I had the overlays on, I couldn't see this message.

It looks like the error page needs some CSS to make it stretch the overlay porthole to fix the whole message (which in this case was quite long).

CommentFileSizeAuthor
#12 ff3_after_patch.png71.15 KBsivaji_ganesh_jojodae
#12 ff3_before_patch.png68.37 KBsivaji_ganesh_jojodae
#12 ie8_after_patch.png77.19 KBsivaji_ganesh_jojodae
#12 ie8_before_patch.png80.16 KBsivaji_ganesh_jojodae
#11 overlaysevenmaintenance.patch1.29 KBcasey
#10 overlaysevenmaintenance.patch1.38 KBcasey
#1 Page 1 | My Website.jpg56.74 KBjensimmons

Comments

jensimmons’s picture

jensimmons commented
StatusFileSize
new Page 1 | My Website.jpg56.74 KB

kiphaas7’s picture

kiphaas7 commented

Could you also please list which browser (version) and/or operating system you're using? Sometimes these bugs are browserspecific. Also, did you encounter this message in other situations?

If you could describe a situation where we can easily reproduce this bug, it would be very helpful.

jensimmons’s picture

jensimmons commented

This was in Safari 4.0.4 on a Mac running OSX.6.2.

I don't know how to reproduce this. I expect anything you do to cause your Drupal installation to display an error message would do this. In my case, I could see this again if I go crash the mySQL database container serving this site.

I don't think this error message is showing up in the $message slot. I think it's one of those errors that shows up at the top of the page, before everything. But also, I'm not sure.

mcrittenden’s picture

mcrittenden commented

Sub.

aspilicious’s picture

aspilicious commented

I am working in google chrome (dev 4)
When I tried to install a module this afternoon I had the same thing.
There was an error while installing the module and I couldn't read the error message, I only saw the top of the orange box.
As I am not a drupal pro, I don't wonna interupt this discussion but i found it worth mentioning.

jensimmons’s picture

jensimmons commented
Priority: Normal » Critical

Since this is a confirmed bug, I'm going to bump it to critical. D7 can't ship with the inability to show error messages when the overlay is on.

aspilicious’s picture

aspilicious commented

This can be a webkit problem like the scrollbar problem i had...
Maybe the webkit wizzes know more...

casey’s picture

casey commented

Not a webkit issue. I think this only happens with fatal errors where execution doesn't reach overlay.

kiphaas7’s picture

kiphaas7 commented

Overlay obviously defaults to the min-height of 100px in these screenshots, so something is going wrong with the height calculation.

A wild guess, since my dev pc is still in pieces:

  // Only set height when iframe content is loaded.
  if ($.isObject(self.$iframeBody)) {
    height = self.$iframeBody.outerHeight() + 25;

Is the body tag even set on pages with these errors? Probably not, hence the default 100px.

casey’s picture

casey commented
Status: Active » Needs review
StatusFileSize
new overlaysevenmaintenance.patch1.38 KB

This was actually happening when overlay was displaying a maintenance page for theme seven.

overlay_preprocess_maintenance_page() isn't actually necessary to fix this issue, but I think it should be there anyway.

casey’s picture

casey commented
StatusFileSize
new overlaysevenmaintenance.patch1.29 KB

We can reuse overlay_preprocess_html()

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
StatusFileSize
new ie8_before_patch.png80.16 KB
new ie8_after_patch.png77.19 KB
new ff3_before_patch.png68.37 KB
new ff3_after_patch.png71.15 KB

#11 works good on various browsers. Tested with Firefox 3*, Chrome 4 and Opera 10 in ubuntu 9.10 and IE8* in windows xp over Virtualbox.

aspilicious’s picture

aspilicious commented

RTBC?

jensimmons’s picture

jensimmons commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Oh! Nice one. I've run across this too, but obviously forgot to look for an issue about it.

The fix looks fairly straight-forward to me. Committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.