This one is weird, and I haven't tracked down the root cause of the issue yet. However it appears that only the first item that has a RRULE defined will be displayed in the ical feed. All subsequent items will be sillently dropped from the ical. They all still display in the HTML calendars, but not in the ical.

CommentFileSizeAuthor
#5 calendar-rrule-fix.patch900 bytesyath0r
#1 rrule-fix.patch677 bytessdague

Comments

sdague’s picture

sdague commented
Issue tags: +patch
StatusFileSize
new rrule-fix.patch677 bytes

Ok, I found a mostly good fix for this, though I expect this will still fail in the case where the RRULE for 2 items turn out to be the same (i.e. 2 different items that both happen every 2nd tuesday). However, it is much better than the current situation where you can only have 1 item with any RRULE in your calendar come up in ical.

Patch attached.

sdague’s picture

sdague commented
Status: Active » Needs review

Patch is included, please take a look.

sdague’s picture

sdague commented

bump. It would be good if this got looked at.

sdague’s picture

sdague commented
Version: 6.x-2.2 » 6.x-2.x-dev

*tap* *tap* is this thing on? Seriously, it would be nice to get some review here.

yath0r’s picture

yath0r commented
StatusFileSize
new calendar-rrule-fix.patch900 bytes

Here's a revised patch which allows for two entries with the same rrule.

CandC540’s picture

CandC540 commented
Status: Needs review » Needs work

#5 doesn't work for me. I have applied the patch. You can check out my iCal feed at http://www.wilshireave.com/calendar I left the patch applied for you to check out the output.

yath0r’s picture

yath0r commented

@CandC540: Thanks for checking that out. I'm not sure I'm seeing the issue. The 'Classic' and 'Casual' entries on your calendar both have the same RRULE and are both rendering in your iCal feed. Is something else broken?

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Issue summary: View changes
Status: Needs work » Closed (outdated)

6.x is entirely unmaintained.