Closed (fixed)
Project:
Views Group By
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
28 Dec 2009 at 11:48 UTC
Updated:
9 Apr 2012 at 08:51 UTC
Jump to comment: Most recent file
Comments
Comment #1
cerup commentedI''d also like to know.
Comment #2
irakli commentedLast I checked, sum aggregation needs a patch to Views module. I will have to check again and will post response/patch. Will try to do it sooner rather than later.
Thanks.
Comment #3
SanDiego commentedSUM, AVERAGE, etc. type of functions would be a great addition to functionality. Looking forward to receiving the patch. Thanks...
Comment #4
redben commentedRe-changing title
Comment #5
Skispcs commentedI would also like the SUM and other features.
Comment #6
chrisirhc commentedHere's a diff of my changes in order to make it work with MIN (tested), MAX, SUM, AVG. (This is based on the 6.x-rc2 release and it is not the standard patch)
It's cleaner than the patch given in: #702176: Rewriting GROUP BY part of the SQL and cheating to integrate Sum and Avg functions
Could someone please test this out for me?
Comment #7
dafederWorking for me so far, thanks!
Comment #8
servantleader commentedWorks great for me. I was using the MIN function in my use case. No errors or problems.
Comment #9
rsevero commentedI've just adapted the patch from comment #6 so it can be applied in current code and tested it. It's working fine.
Please consider integrating it into code.
Comment #10
jm.federico commentedPatch againts RC2 (reversed, DO NOT USE) check #14
Comment #11
frjo commentedI have been testing patch #9 on a local dev site and it works well. I'm using the "sum" function. Have not encountered any problems, error messages in the log etc.
Comment #12
NaX commentedI am using #9 without any problems. Based on the feedback here I think this is ready to be committed.
Please note that it looks like the patch on #10 is inverted, like a rollback/remove feature patch.
Comment #13
bfellows commentedThis is a great addition to the v-groupby module. I was able to successfully patch the module manually; I am a linux idiot and couldn't get it to take via the command line patch util.
Comment #14
jm.federico commentedRerolling againts RC2. patch in #10 is reversed.
@NaX: thanks
Comment #15
mattiasj commentedThanks alot for this patch, truly helped out and works like a charm.
Comment #16
lord_of_freaks commentedSuscribing
Comment #17
mjumbewu commentedSubscribing
Comment #18
arithmetric commentedAttached is an updated patch for the latest dev version (6.x-1.x) from the patch on #14 (which is for 6.x-1.0-rc2).
Comment #19
patcon commentedHoly crap. This is awesome. Is anyone taking donations for this?! It totally just saved my keister.
Comment #20
patcon commentedOh hey, here's a patch that will work with drush_make (-p0 instead of -p1, which is needed to strip off the module directory).
Comment #21
patcon commentedWow. This, along with views_customfields, makes views so fracking powerful. I'm blown away by how well this works. Just, wow.
Comment #22
obrienmd commentedWhen trying to patch latest 6.x-1.x-dev with #18 or #20, I get:
Comment #23
patcon commented#20 is for the stable rc, since I needed a non-moving target for my drush_make files. But there's no dev build more recent than what #18 was rolled against anyhow. trying patching with the dev one from within the actual module's folder with -p0, and it should work :)
~/path/to/dir/views_groupby $ patch -p0 < patchie-patch-patch.patch
Comment #24
obrienmd commentedLooks like that worked, thanks :)
Comment #25
Shadlington commentedJust chipping in to say that #20 worked great for me. This should really get committed...
Comment #26
obrienmd commentedAgreed, this needs to be committed ASAP. I makes the module much more widely useful.
Comment #27
patcon commentedI totally agree. This patch by @chrisirhc is really clean, and it would be great to see #20 committed. Works great for me.
Comment #28
justafish#20 also worked well against rc2 for me. Any reason we can't commit this?
Comment #29
obrienmd commentedUpdate: irakli has let me know s/he will be reviewing this soon!
Comment #30
patcon commentedAwesome!
Comment #31
jm.federico commentedAbsolutely fantastic! Thanks!
Comment #32
mattiasj commentedthanks!
Comment #33
bobju commentedThanks! :-)
Comment #34
irakli commentedComitted: http://drupal.org/cvs?commit=484634
Comment #36
hartogsmith commentedmassive, massive thank for the original module and this patch.
Comment #37
joya commentedSubscribing
Comment #38
hendrohwibowo commented#20 and #23 works like a charm.
Sorry if this issue is already closed. I just try drupal for one month (mar 2012) and i have to express my thank yo since i am relieved by the patch.
Thank you again