Hi, I am the maintainer of customcssjs module. (http://drupal.org/project/issues/customcssjs)

I understand my module is quite similar with slight differences and I would like to know what do you think about merging both modules.

The "added" functionality to this one is just having a folder for scanning css and js files and add them via drupal_add_[css|js]() besides the possibility of entering the styles as this module already provides.

Comments

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

subscribing...

mlncn’s picture

mlncn commented

+1

And has anyone talked to the maintainers of http://drupal.org/project/css -- the ability to create / edit the css_injector css from node edit pages would replace css module (and be awesome).

benjamin, agaric

bachbach’s picture

bachbach commented

hi,

i have posted a issue in CVS applications for a module i have made.
His purpose is to automaticly inject css and js files from the current theme.
it looks for css and js files by name based on args, alias, nid, etc,

style-node.css, style-user-1.css, juste like the page.tpl.php page-node.tpl.php systeme

http://drupal.org/node/692810

it may be a good thing to think about merging our three modules ?

mrfelton’s picture

mrfelton commented

Also worth adding http://drupal.org/project/js_injector to this discussion, since that already deals with injecting JS in exactly the same way as css_injector does.

binford2k’s picture

binford2k commented

js_injector is just a fork of this module.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

I think that both modules (CSS Injector & JS Injector) should be merged under the (abandoned) Custom CSS and JavaScript files project. Especially if they use same/similar mechanism and share code. Alternatively, a new project can be created (say 'CSS & JS Injector') that would house both projects. Really, is the css_js_injector namespace taken?

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

@klonos, you keep working the queue and you'll end up a comaintainer too :-)

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

...as for the CSS project mentioned in #2 by Benjamin, I believe it deals with a whole different thing. I think it targets node css and not theme specific css. IOW doesn't actually help with theming -IMHO.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

@rfay: LOL! I don't have the coding skills or drupal code know-how level (yet), but as it says in my profile: 'I help in the Drupal support forums'. It is my way of giving back.

btw, congrats on your 'promotion' Randy ;)

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

...more news regarding the CSS project's functionality and efforts to merge its features in css_injector here: #437006: Added CSS fieldset for node/edit

@Benjamin Melançon, #2: you'll find two patches in the liked issue (+a screenshot). Do try them out, but be careful as they were posted back in April 2009. Don't forget to provide feedback (be it for success or failure).

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Active » Fixed

@davebv, I definitely encourage you to take over the capabilities in this module. This is essentially unmaintained, so if you're willing to maintain, it would be much better in your module.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.