Closed (fixed)
Project:
Nodewords: D6 Meta Tags
Version:
6.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
28 Dec 2009 at 17:31 UTC
Updated:
15 Aug 2012 at 17:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
avpadernoI think I fixed the problem with the last commit I made. I changed the value returned from
hook_nodewords_api(), which was a floating point value and it is now a string; that value is passed toversion_compare(), and it could have caused the failure of the versions comparison.I also changed the error message reported in such cases; now it points out that there are no modules implementing meta tags, or that support the current API version.
Thanks for the report; I apologize for any trouble given by this issue.
Comment #2
michelleThanks, I'll update when the new dev comes out this evening and let you know.
Michelle
Comment #3
michelleOk, dev installed and fix confirmed. Thanks!
Michelle
Comment #4
avpadernoThanks to you for pointing out the problem. I don't really know why it was working, last time I checked it.
I will change the code to make it enable nodewords_basic.module, if it doesn't find any modules implementing meta tags. I think this should be a better solution.
Comment #5
michelleGlad it was a quick fix. :)
You can also put it in the status report rather than an error on every page.
Michelle
Comment #6
avpadernoThe message is also reported in the status report, but it actually checks if there are modules implementing meta tags, not the actual version implemented.
I put the message in the settings page because I had some reports about the meta tags not being listed in the settings page. I think that I will remove the error message, and add that code that enables nodewords_basic.module in the case it is not enabled, and there aren't any module currently defining meta tags (or supporting the current API version).
Comment #7
avpadernoFYI, I removed the code to automatically enable nodewords_basic.module.
I was too focused on finding a solution that would not require the user to do anything that I forgot a detail; if the user would be uninstalling Nodewords, that code would not allow to disable the modules because it would re-enable nodewords_basic.module if the other modules are not enabled.
I apologize for my stupidity.
Comment #8
michelleOh, I hadn't thought of that. :)
Michelle
Comment #9
nbluto commentedThank you so much for fixing this. I just noticed this weekend that that bug existed on a site that will go live tomorrow! Nice to look for an answer and find it right away.
Comment #12
gr33nman commentedDrupal 6.24
Just updated all modules.
Had to disable nodewords for this message:
The link on 'pageArray' led to '/sites/reports/status@modules'
After re-enabling, the oddness disappeared. Cannot reproduce.
Comment #13
damienmckennaThe module's logic seems fine, but I've tweaked the language a little.
Comment #14
damienmckennaCommitted.
Comment #16
kenheim commentedI applied the patch, cleared cache, but the error message below remains in my status report.
"Enable at least one module listed under the Meta tags category on the modules page.Array
There are no modules enabled that implement meta tags."
Comment #17
damienmckenna#facepalm.
Comment #18
damienmckennaCommitted.