In the phpbb_api_theme.php file, the following 2 instances of the link to the users inbox have invalid & chars where & should be used on lines 299 and 304.

Minor bug, but causes validation errors. (The correct code is used within phpbb itself for inbox links.)

$str = '<a href="'. $phpbb_url .'/ucp.php?i=pm&folder=inbox">'. $l_privmsgs_text .'</a>';
$str = '<br />'.'<a href="'. $phpbb_url .'/ucp.php?i=pm&folder=inbox">'. $l_privmsgs_text_unread .'</a>';

should be changed to

$str = '<a href="'. $phpbb_url .'/ucp.php?i=pm&amp;folder=inbox">'. $l_privmsgs_text .'</a>';
$str = '<br />'.'<a href="'. $phpbb_url .'/ucp.php?i=pm&amp;folder=inbox">'. $l_privmsgs_text_unread .'</a>';

Thank you. :)

Comments

phreadom’s picture

phreadom commented

Argh... drupal interpreted my ampersand... :(
Let me repost the comment to correct it and make it a little easier to understand.

In the phpbb_api_theme.php file, the following 2 instances of the link to the users inbox have invalid & chars where &amp; should be used on lines 299 and 304.

Minor bug, but causes validation errors. (phpbb itself uses the correct valid xhtml for such links)

line 299:
$str = '<a href="'. $phpbb_url .'/ucp.php?i=pm&folder=inbox">'. $l_privmsgs_text .'</a>';

line 304:
$str = '<br />'.'<a href="'. $phpbb_url .'/ucp.php?i=pm&folder=inbox">'. $l_privmsgs_text_unread .'</a>';

should be changed to

line 299:
$str = '<a href="'. $phpbb_url .'/ucp.php?i=pm&amp;folder=inbox">'. $l_privmsgs_text .'</a>';

line 304:
$str = '<br />'.'<a href="'. $phpbb_url .'/ucp.php?i=pm&amp;folder=inbox">'. $l_privmsgs_text_unread .'</a>';

fizk’s picture

fizk commented
Status: Active » Closed (fixed)