layout.css is missing a

.no-sidebars #content {
  width: /* maths needs doing */
}
CommentFileSizeAuthor
#6 Picture 1.png35.7 KBpsynaptic

Comments

psynaptic’s picture

Status: Active » Needs review

I did some layout fixes yesterday so hopefully this was fixed with those changes. Could you update and let me know?

joachim’s picture

Nope, no sign of a width on #content with no sidebars.

joachim’s picture

Status: Needs review » Active
psynaptic’s picture

Did you just look at the CSS without testing in the browser? There is no need to explicitely set a width and the theme collapses based on columns. When there are no sidebars the content div takes up the full width. Only on pages with sidebars does the content div need an explicit width.

Please can you confirm you can see a problem in the browser?

joachim’s picture

If the node being shown with no sidebars is quite short, just a few lines of text, then its width is LESS than the maximum. And then any styling like borders of background is wrong.

Eg:

Welcome to this site.
This is another short line.

Which is more or less what a client wanted.

psynaptic’s picture

Status: Active » Fixed
StatusFileSize
new35.7 KB

I have taken a screenshot of the theme with no sidebars highlighting the #content div (using Firebug).

As you can see, it takes up the full width available. This is so that pages with wide content e.g. admin pages, node forms, etc. can be given the full width.

I'm not entirely sure I understand what you are saying but it sounds like it is something that should be specific to that individual site.

joachim’s picture

Yup, fixed in the lastest from CVS: this change fixed it:

.no-sidebars #content {
float:none;
}

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.