Add a static cache to actions_get_all_actions()

I'll try to help things going...
A try to fix previous patch

1) remove windows line endings (check)
2) 2 spaces indentation (check)
3) no tabs (check)
4) readable patch name... (check)
5) path name (check)
6) test on local machine (check)

Ok lets see what bot thinks

Ok it passed...
Now the real reviews can come in

#3: action-add-static-cache-669732-3.patch queued for re-testing.

The current code reads:

function actions_get_all_actions() {
  $actions = &drupal_static(__FUNCTION__, array());
  if (count($actions)) {
    return $actions;
  }
  else {
    $actions = db_query("SELECT aid, type, callback, parameters, label FROM {actions}")->fetchAllAssoc('aid', PDO::FETCH_ASSOC);
    foreach ($actions as &$action) {
      $action['configurable'] = (bool) $action['parameters'];
      unset($action['parameters']);
      unset($action['aid']);
    }
  }
  return $actions;
}

this could be shortened to:

function actions_get_all_actions() {
  $actions = &drupal_static(__FUNCTION__);
  if (!isset($actions)) {
    $actions = db_query("SELECT aid, type, callback, parameters, label FROM {actions}")->fetchAllAssoc('aid', PDO::FETCH_ASSOC);
    foreach ($actions as &$action) {
      $action['configurable'] = (bool) $action['parameters'];
      unset($action['parameters']);
      unset($action['aid']);
    }
  }
  return $actions;
}

I think that the second is more concise and more readable.

Unassigning.