CVS edit link for gmaurol

The Google Friend Connect plugin for Drupal allows you, as a site adminitrator, to let your users to authenticate using their OpenID accounts and comment your content. Optionally, you can replace the Drupal comments functionality by Google Friend Connect comments gadget, or reviews gadget.

You can add a Google Friend Connect social bar, members gadget, site comments gadget or recommendations in your site section of choice.

When you add a new piece of content, someone posts a comment or someone recommends an article using the recommendation button, activities are posted to the Google Friend Connect activity streams.

CommentFileSizeAuthor
#4 drupal-friendconnect.zip18.14 KBgmaurol
#1 friendconnect.zip43.25 KBgmaurol

Comments

gmaurol’s picture

Component: Miscellaneous » Code
Assigned: Unassigned » gmaurol
Status: Postponed (maintainer needs more info) » Active
StatusFileSize
new43.25 KB

Please, see README file in the attached package.

dawehner’s picture

Component: Code » Miscellaneous
Assigned: gmaurol » Unassigned
Status: Active » Needs work

Update status etc.


/**
 * Copyright 2009 Google Inc.
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *
 * Plugin Name: Friend Connect Commenting Plugin
 * Version: 1.0
 * Description: This plugin allows a user to leave comments using his or
 * her Friend Connect (http://www.google.com/friendconnect/) id to signin.
 * More description can be found in the attached README file, or at
 *
 * http://code.google.com/p/google-friend-connect-plugins
 */


/**

.
Its not allowed to host non-GPL code on drupal.org. I think .module files cannot be licensed under something different then gpl, because it uses the api direct.

I suggest you to split up your code into .admin.inc and .pages.inc

avpaderno’s picture

Status: Needs work » Closed (won't fix)

There have not been replies from the OP in the past 7 days. I am marking this report as won't fix.

gmaurol’s picture

Status: Closed (won't fix) » Needs review
StatusFileSize
new18.14 KB

Hello, I've removed the APL license headers, since it's ok to release the plugin under GPLv2, also splitted the code into admin.inc and pages.inc as suggested.
Attached as drupal-friendconnect.zip
Cheers

Mauro

dave reid’s picture

Status: Needs review » Closed (won't fix)

Did you not realize http://drupal.org/project/friendconnect already existed?

dave reid’s picture

Also want to note that I'm more than willing to accept any patches for the existing module.

gmaurol’s picture

Good to hear, let me talk to google