Make CCK compatible with both, views 2 and views 3

This is probably another case of CCK not being updated for the Retool Exports patch, where it needs to be sure any fields it has are in the option_definition().

I warn you that Views 3.x-dev is likely to be somewhat unstable, and your comment about really really needing to get it working suggests to me you should be using the 2.x branch instead.

I'm pretty sure the fix is easy. In Views 3, the drop is moving, so to speak, and other modules have to catch up to its changes; and I think they mostly will not bother doing so until we are done making changes.

In my particular case, since I'm using Views 2 for the project I'm working on, I have very little idea on how Views 3 inners are changing. If there was documentation somewhere about where to look so that developers can adapt their modules to Views 3 faster... any pointer to start with?

PS: I guess this is not a CCK3 issue per se. It should be first addressed for CCK2, then we'll port to CCK3.

Uhh. We haven't gotten to the point where we're formally documenting stuff. In this case, the change is that any value that your handler or plugin stores *must* be in the option_definition() where before you could stick any old value you wanted in there.

(If you need a dynamic area, make an array and make your dynamic values part of the array)

Sorry for change the title of this issue, but since @merlinofchaos and @markus_petrux had commented in this thread, we can get a confirmation if this patch is working fine.

Several modules like Content Profile, Date, Link, Flag are still using views_handler::options(&$options) {} to define options for this fields/filters/arguments.

This is not supported any more by views 3. We should use option_definition() as merlinofchaos post in #5.

I have tested this patch with CCK 2.5 and Views 2.7, and with the last developtment version of view 3 and seems to be working without problems.

Here is the patch.

@dagmar: Thank you very much. The patch looks good to me.

Hi all, since I'm short on time to test, I would appreciate feedback on testing the patch in #6 with Views 2 and 3.

I think we can commit this as soon as we have a few affirmative reports.

Confirmed the issue with CCK and Views 3 and I had duplicates opened at http://drupal.org/node/672694 and http://drupal.org/node/665594
Patch applied smoothly and it fixed the issue of not being able to change the CCK field 'Label' and 'Format' in Views.
Thanks for the great work!

I'm already using views 3 even as dev version as the new features are great!
The patch works great. I hope these patches get committed soon in support.

I think somebody should confirm that this work without problems in views 2. I have tested it using views 2 and views 3 but my test were very superficial.

Yes this is good for Views 2.

We should get this committed ASAP -- We're releasing Views 3 alpha2 today and people are going to need this patch. I will reference this patch in the release notes.

Ok, committed to CVS.

http://drupal.org/cvs?commit=319604 (CCK2)
http://drupal.org/cvs?commit=319610 (CCK3)

Thanks for your patience

@markus_petrux: Is it time for another cck dot release? The last one was November 5th.

For others running into this problem, the patch in #6 applies to CCK 6.x-2.6 and fixes the problem of a field formatter not getting saved.

The patch works for me, however, it creates an unnecessary <p></p> around the entry in an HTML list and then the list looks odd, because there's a separate empty line between each bullet.

I'm using drupal core 6.16, cck 6.x-2.6, views 6.x-3.0-alpha2.

Let me add that the custom field is a text field and contains a link (so it can't be displayed in plain text format), so probably it should be enclosed in <p></p>. Is there a way to get rid of the <p></p> although it's a textfield?

Can the patch be applied to CCK 6.x-2.5? I will be updating us to 2.6 as soon as possible but just can't do it at this time -- but I was hoping to upgrade to Views 3 if I can. Thank you!

i don't see a reason why you shouldn't update to 2.6. In contrast to views3 its a stable software.

@alisonjo2686: you can apply the patch to your own local cck installation, see http://drupal.org/patch

Tags cannot be modified, this means, CCK 2.5 will no be changed anymore.

thanks for the responses!

@dereine -- the reason is just time; this particular site is a multisite setup and I'm behind on a number of module updates, including some CCK-related modules, so it will take a significant time to upgrade the various intertwined modules, and while the process is simple, it's tedious and there are many opportunities for stupid mistakes (for me anyway). anyway, that's all, I will make the updates as soon as possible, I just haven't had the time yet.

@dagmar -- thank you, I realized after reading your response that back when you originally posted the patch it was intended for 2.5 anyway; I read this thread of comments backwards and because of more recent comments (when people said the patched worked for 2.6) thought it was meant for 2.6.

Anyway, hopefully I didn't just make things more confusing... the point is, I'm 98% sure I'm good to go, and thank you for all the help!!

Ok, it seems to be fixed.

Related issues:
#783502: Image-fields stuck on "generic files"
#665594: Field Content Image Format does not stick, changes back to Generic Files
#672694: Widget label can't be changed to None or Custom
#665594: Field Content Image Format does not stick, changes back to Generic Files

Cool - it's now in the official 6.x-2.7 release :-)