Modules should probably never do this. All it does it ensure that any theme that does not want to use your font has yet another style to override. Here is a patch to remove it.

CommentFileSizeAuthor
overlay-font.patch542 bytesjacine

Comments

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

David_Rothstein’s picture

David_Rothstein commented

Not that simple, unfortunately :( I believe this causes #700832: Parts of the overlay inherit CSS from the underlying site theme, leading to a font mismatch in the overlay page title

jacine’s picture

jacine
she/her
Location New York
commented

While the font issue is valid, the solution cannot be to pile on another assumed font-family in a modules CSS, but the instead the it needs to be addressed at the source. In this case that source is ui.theme.css.

A patch has been proposed for Seven here that fixes this problem and then some: #614494: Give Seven a nice looking default jQuery UI theme

Also, your issue is a duplicate of: #682884: jQuery ui sneaks in an undesired font-stack for overlay headers and tabs

David_Rothstein’s picture

David_Rothstein commented

While the font issue is valid, the solution cannot be to pile on another assumed font-family in a modules CSS, but the instead the it needs to be addressed at the source.

Agreed. That's one of the reasons I started a new issue rather than reopened this one.

In this case that source is ui.theme.css.

Actually, the source is some confusing mismatch of Garland and ui.theme.css, as explained more fully there. Let's continue discussion at #682884: jQuery ui sneaks in an undesired font-stack for overlay headers and tabs, although it's not quite a duplicate.

Hm, I'm starting to get a feeling that the overlay will be a theming nightmare unless something gets done about the fundamental problem underlying all of this :(