Changing task attributes while commenting, as in drupal.org's project_issue [#671156]

I often find myself commenting on a task and, moments later, changing its status to completed. In project_issue, used on drupal.org issue queues, a nice feature is allowing commenters to change certain attributes of the issue while making a comment.

I am proposing a simple node_alter to the comment form for stormtask which would allow a commenter to make changes to the category, status and priority of the task while commenting on it (see attached image)

(Note that the comment_cck can change cck data during commenting, but it does not really apply to storm tasks because fields are not implemented through cck.)

Comment	File	Size	Author
#1	671156.1.storm_.modify_task_with_comment.patch	3.78 KB	alberto56
	Screen shot 2009-12-30 at 5.17.44 PM.png	27.21 KB	alberto56

Comments

Comment #1

alberto56 commented 30 December 2009 at 22:28

Status:

Active

» Needs review

Status	File	Size
new	671156.1.storm_.modify_task_with_comment.patch	3.78 KB

Here is the first version of a patch that works for me. Perhaps it might be nice to align the selection fields, and maybe even allow the user to disable the feature entirely if anyone finds it intrusive.

Comment #2

Magnity commented 4 January 2010 at 18:13

I'd really like to get this sort of feature in.

I know there are others who have ideas about this type of feature, so will leave to see if anyone else comments on it before getting down to the detail of the patch.

Comment #3

JGonzalez commented 31 January 2010 at 18:53

Was this commited to -dev? I currently have option for "task status" and "assign task to".

I think if priority and category were also added, it'd be nicer to float then all onto one line (like the ones on drupal.org)

Comment #4

Magnity commented 31 January 2010 at 18:54

It hasn't been committed yet - needs review.

Comment #5

Magnity commented 18 February 2010 at 11:46

Activating testbot.

Comment #6

Magnity commented 18 February 2010 at 18:04

Status:

Needs review

» Needs work

+++ stormtask/stormtask.module	30 Dec 2009 22:23:39 -0000
@@ -931,3 +931,73 @@ function stormtask_views_api() {
+ * Note that this method does not take note

Incomplete comment?

+++ stormtask/stormtask.module	30 Dec 2009 22:23:39 -0000
@@ -931,3 +931,73 @@ function stormtask_views_api() {
+        '#title' => t('Modify category'),

Simply say "Category"

+++ stormtask/stormtask.module	30 Dec 2009 22:23:39 -0000
@@ -931,3 +931,73 @@ function stormtask_views_api() {
+        '#title' => t('Modify status'),

Simply say Status

+++ stormtask/stormtask.module	30 Dec 2009 22:23:39 -0000
@@ -931,3 +931,73 @@ function stormtask_views_api() {
+        '#title' => t('Modify priority'),

Simply say Priority

+++ stormtask/stormtask.module	30 Dec 2009 22:23:39 -0000
@@ -931,3 +931,73 @@ function stormtask_views_api() {
+  } // end if ($node->type == 'stormtask' && stormtask_access('update', $node))

Simply 'end if' would suffice

Also: indentation for comments should be at the same level as the code it is in. Comments generally could be made a little more concise if possible.

It'd be great if we could put all of the dropdowns on one horizontal line.

Powered by Dreditor.

Comment #7

alberto56 commented 23 April 2010 at 00:48

With the patch in #1, a problem occurs if the comment body is empty. This causes a validation error, and the fields to change attributes disappear.

Comment #8

corydorning commented 30 April 2010 at 13:55

Any further work done on this? I'd be willing to donate $15-$20 to get this started. (it isn't much, but it's a start) ;)

Comment #9

mmilo commented 3 May 2010 at 15:29

Subscribing ...

Hopefully sometime in the future I can give a shot at this.

I think it'd be better to use something like http://drupal.org/project/driven (I haven't taken a look at the API yet tbh), which would remove the need for Storm to use a custom implementation.