Closed (outdated)
Project:
Blog
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
31 Dec 2009 at 09:57 UTC
Updated:
1 Mar 2016 at 12:07 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
robloachGrrr.
Comment #3
aspilicious commentedStill apllies.
Adding a class to an element is always usefull.
Lets get this in!
Comment #4
realityloop commented#2: blogactions.patch queued for re-testing.
Comment #5
webchickHm. This seems like odd special-casing. If this is a problem for Blog, it's going to be a problem for Forum, too (at least; probably elsewhere as well). Let's develop a standard and apply it consistently.
Also, 'node-add-blog'? Can we choose something a bit more semantic, or not really?
Comment #6
robloachGood call. This moves it over to hook_menu_local_tasks_alter() instead, like the Forum module. This gives us the "action-links" class on the ul.
Comment #7
joachim commentedDuplicate of #784842: shouldn't the "post new blog entry" link have 'action-links' class?, maybe?
Comment #8
naheemsays commentedOr the other way around - this seems to cover more stuff correctly from what I can see. Lets see what the bot says.
Comment #9
joachim commentedFor consistency with forum module, maybe do this:
Comment #10
naheemsays commented#6: blog-action-links.patch queued for re-testing.
Comment #11
dries commentedUsing hook_menu_local_tasks_alter() is the proper thing to do. Happy to commit this when marked RTBC.
Comment #12
naheemsays commentedPatch seems simple enough. No white space issues and it does what it says on the tin.
Not really sure what Joachim was asking for in #9 and the current stuff seems to work.
Comment #14
webchickCommitted to HEAD. Thanks!
Comment #15
joachim commented> Not really sure what Joachim was asking for in #9 and the current stuff seems to work.
Consistency in code with forum module! ;)
Comment #16
joachim commentedForum module keys its 'You are not allowed...' link with a different key. This is perhaps important?
Comment #17
marcingy commentedThis is a string change, blog module is no longer in d8 so the follow up is won't fix.
Comment #18
joachim commentedMoving to the Blog module.
Comment #19
chris_hall_hu_cheng commentedAs this issue was carried over from Core, when Blog was in core, and is no longer relevant I am closing it.