Hello everybody,

this is really just trivial, but here it goes...

At this stage, there are the following sets of buttons available ('*' in both sides of button name denotes activate/highlighted button):

[*Menu Groups*] [Term Sets]
[*Menu Groups*] [New Menu Group]

and:

[Menu Groups] [*Term Sets*]
[*Term Sets*] [Add Term Set]

Here's my proposal. I agree that it is just fine the way it is (once you've got the hang of it), but I think it would be better this way:

[*Menu Groups*] [Term Sets]
[Add Menu Group]

and:

[Menu Groups] [*Term Sets*]
[Add Term Set]

In the above proposed sets the word 'Add' could also be 'New', but either way we need to stick with one (whereas now it is 'Add' for the sets and 'New' for the groups).

As for the secondary [*Menu Groups*] and [*Term Sets*] buttons before the Add/New buttons, I think they should be removed, since you can go to the list of terms or groups by hitting the respective top-level buttons.

As I said in the beginning this is really trivial and I've marked this issue as 'minor', but if you guys agree and like my proposal better, I'd like to see it implemented. Thanx in advance for your time.

Wish you all a happy/ier 2010 ;)

Comments

indytechcook’s picture

indytechcook commented

I agree with the names of the tabs. New Menu Group has been changed to "Add Menu Group" but I don't think it's possible to not have the first sub tab. I used hook_menu to created the tabs with the structure below. If I remove the entry for group/list is makes both sub tabs unavailable.

  $base = 'admin/build/taxonomy_menu';
  $admin_file = 'taxonomy_menu.admin.inc';
  $items[$base] = array(
    'title' => 'Taxonomy Menu',
    'type' => MENU_NORMAL_ITEM,
    'access arguments' => array('taxonomy menu admin'),
    'page callback' => 'taxonomy_menu_group_list',
    'file' => $admin_file,
  );
  $items["$base/group"] = array(
    'title' => 'Menu Groups',
    'type' => MENU_DEFAULT_LOCAL_TASK,
  );
  $items["$base/group/list"] = array(
    'title' => 'Menu Groups',
    'type' => MENU_DEFAULT_LOCAL_TASK,
    'weight' => 0,
  );
  $items["$base/group/add"] = array(
    'title' => 'Add Menu Group',
    'type' => MENU_LOCAL_TASK,
    'page callback' => 'drupal_get_form',
    'page arguments' => array('taxonomy_menu_group_form'),
    'weight' => 1,
    'access arguments' => array('taxonomy menu admin'),
    'file' => $admin_file,
  );
arlinsandbulte’s picture

arlinsandbulte commented

Yep, I agree with the names.

Regarding the extra sub-ta,. I think this is just the way Drupal works. I see your point, but I think there is a valid reason for the way it is too.

indytechcook’s picture

indytechcook commented
Status: Active » Fixed

Changed http://drupal.org/cvs?commit=308632. The List tab will stay.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.